Fixed the rollback functionality to work with empty gas price database #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Aug 20, 2024
Comment on lines
257
to
259
| let gas_price_rollbacked = gas_price_chain_height.is_none() | ||
| || gas_price_chain_height.expect("We checked height before") | ||
| == target_block_height; |
There was a problem hiding this comment.
Suggested change
| let gas_price_rollbacked = gas_price_chain_height.is_none() | |
| || gas_price_chain_height.expect("We checked height before") | |
| == target_block_height; | |
| let gas_price_rolled_back = gas_price_chain_height.is_none() | |
| || gas_price_chain_height.expect("We checked height before") | |
| == target_block_height; |
There was a problem hiding this comment.
roll_backed vs rolled_back, I think latter is preferred
|
|
||
| if on_chain_height == target_block_height | ||
| && off_chain_height == target_block_height | ||
| && gas_price_chain_height == target_block_height | ||
| && gas_price_rollbacked |
There was a problem hiding this comment.
Suggested change
| && gas_price_rollbacked | |
| && gas_price_rolled_back |
|
|
||
| // When | ||
| let args = [ | ||
| "_IGNORED_", |
There was a problem hiding this comment.
I've seen this being used in other tests too, what does this mean?
There was a problem hiding this comment.
That's the first (shell) command argument, which is usually the path to the binary. Since the executable name isn't used for anything and pointing to the real fuel-core binary would make no sense, just having a dummy string here is fine.
Dentosal
previously approved these changes
Aug 20, 2024
Dentosal
previously approved these changes
Aug 20, 2024
…atabase-doesnt-exist' into bugfix/rollback-when-gas-price-database-doesnt-exist
rymnc
approved these changes
Aug 20, 2024
Dentosal
approved these changes
Aug 20, 2024
xgreenx
deleted the
bugfix/rollback-when-gas-price-database-doesnt-exist
branch
Merged
xgreenx
added a commit
that referenced
this pull request
Aug 20, 2024
## Version v0.34.0 ### Added - [2051](#2051): Add support for AWS KMS signing for the PoA consensus module. The new key can be specified with `--consensus-aws-kms AWS_KEY_ARN`. - [2092](#2092): Allow iterating by keys in rocksdb, and other storages. - [2096](#2096): GraphQL endpoint to fetch blob byte code by its blob ID. ### Changed - [2106](#2106): Remove deadline clock in POA and replace with tokio time functions. #### Breaking - [2051](#2051): Misdocumented `CONSENSUS_KEY` environ variable has been removed, use `CONSENSUS_KEY_SECRET` instead. Also raises MSRV to `1.79.0`. ### Fixed - [2106](#2106): Handle the case when nodes with overriding start on the fresh network. - [2105](#2105): Fixed the rollback functionality to work with empty gas price database. ## What's Changed * doc: refine the transaction example in the README by @mmyyrroonn in #2072 * AWS KMS block signing support and Rust 1.79 by @Dentosal in #2051 * feat(iterators): allow key-only iteration by @rymnc in #2092 * feat: graphql endpoint to fetch the blob byte code by its blob ID by @netrome in #2096 * Small improvements for tests to make them more stable by @xgreenx in #2103 * Fixed the rollback functionality to work with empty gas price database by @xgreenx in #2105 * Bump wasmtime version by @Dentosal in #2089 * Handle the case when nodes with overriding start on the fresh network by @xgreenx in #2106 * Remove deadline clock in POA and replace with tokio time functions. by @AurelienFT in #2109 ## New Contributors * @mmyyrroonn made their first contribution in #2072 **Full Changelog**: v0.33.0...v0.34.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2104
Checklist
Before requesting review