Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graphql endpoint to fetch the blob byte code by its blob ID #2096

Merged
merged 8 commits into from
Aug 20, 2024
Merged

feat: graphql endpoint to fetch the blob byte code by its blob ID #2096

merged 8 commits into from
Aug 20, 2024

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Aug 16, 2024 •
edited
Loading

Linked Issues/PRs

Description

This PR adds a graphql query to fetch blob bytecode by their ID

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@netrome netrome linked an issue Aug 16, 2024 that may be closed by this pull request
Add a GraphQL endpoint to fetch the blob byte code by its ID #2084
Closed
@netrome netrome changed the title 2084 add a graphql endpoint to fetch the blob byte code by its feat: graphql endpoint to fetch the blob byte code by its ID Aug 19, 2024
@netrome netrome changed the title feat: graphql endpoint to fetch the blob byte code by its ID feat: graphql endpoint to fetch the blob byte code by it's blob ID Aug 19, 2024
@netrome netrome changed the title feat: graphql endpoint to fetch the blob byte code by it's blob ID feat: graphql endpoint to fetch the blob byte code by its blob ID Aug 19, 2024
@netrome netrome force-pushed the 2084-add-a-graphql-endpoint-to-fetch-the-blob-byte-code-by-its-id branch 2 times, most recently from 569d7fe to 53b0c3c Compare August 19, 2024 08:03
@netrome netrome self-assigned this Aug 19, 2024
@netrome netrome marked this pull request as ready for review August 19, 2024 08:07
@netrome netrome requested a review from a team August 19, 2024 08:16
MitchTurner
MitchTurner reviewed Aug 19, 2024
View reviewed changes
tests/tests/blob.rs Outdated Show resolved Hide resolved
MitchTurner
MitchTurner previously approved these changes Aug 19, 2024
View reviewed changes
xgreenx
xgreenx requested changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add code to the fuel-core-client to query blobs and use it for e2e tests as well

@netrome
Copy link
Contributor Author

netrome commented Aug 19, 2024

We also need to add code to the fuel-core-client to query blobs and use it for e2e tests as well

Thanks for the pointer. I have added a query method in the client now and use it in the test instead of the previous custom query method.

@netrome netrome force-pushed the 2084-add-a-graphql-endpoint-to-fetch-the-blob-byte-code-by-its-id branch 2 times, most recently from 74a2317 to 4844957 Compare August 19, 2024 12:42
@netrome netrome requested review from xgreenx and MitchTurner August 19, 2024 12:42
@netrome netrome force-pushed the 2084-add-a-graphql-endpoint-to-fetch-the-blob-byte-code-by-its-id branch from 4844957 to a089b6f Compare August 19, 2024 15:27
@netrome netrome force-pushed the 2084-add-a-graphql-endpoint-to-fetch-the-blob-byte-code-by-its-id branch from a089b6f to a95c7be Compare August 20, 2024 07:06
xgreenx
xgreenx reviewed Aug 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
xgreenx
xgreenx previously approved these changes Aug 20, 2024
View reviewed changes
@netrome netrome requested a review from xgreenx August 20, 2024 08:52
@netrome netrome enabled auto-merge (squash) August 20, 2024 09:07
@netrome netrome merged commit 4c0cd47 into master Aug 20, 2024
32 checks passed
@netrome netrome deleted the 2084-add-a-graphql-endpoint-to-fetch-the-blob-byte-code-by-its-id branch August 20, 2024 09:20
@xgreenx xgreenx mentioned this pull request Aug 20, 2024
Merged
xgreenx added a commit that referenced this pull request Aug 20, 2024
@xgreenx
Release v0.34.0 (#2117)
000646b 
## Version v0.34.0

### Added
- [2051](#2051): Add support
for AWS KMS signing for the PoA consensus module. The new key can be
specified with `--consensus-aws-kms AWS_KEY_ARN`.
- [2092](#2092): Allow
iterating by keys in rocksdb, and other storages.
- [2096](#2096): GraphQL
endpoint to fetch blob byte code by its blob ID.

### Changed
- [2106](#2106): Remove
deadline clock in POA and replace with tokio time functions.

#### Breaking
- [2051](#2051): Misdocumented
`CONSENSUS_KEY` environ variable has been removed, use
`CONSENSUS_KEY_SECRET` instead. Also raises MSRV to `1.79.0`.

### Fixed

- [2106](#2106): Handle the
case when nodes with overriding start on the fresh network.
- [2105](#2105): Fixed the
rollback functionality to work with empty gas price database.

## What's Changed
* doc: refine the transaction example in the README by @mmyyrroonn in
#2072
* AWS KMS block signing support and Rust 1.79 by @Dentosal in
#2051
* feat(iterators): allow key-only iteration by @rymnc in
#2092
* feat: graphql endpoint to fetch the blob byte code by its blob ID by
@netrome in #2096
* Small improvements for tests to make them more stable by @xgreenx in
#2103
* Fixed the rollback functionality to work with empty gas price database
by @xgreenx in #2105
* Bump wasmtime version by @Dentosal in
#2089
* Handle the case when nodes with overriding start on the fresh network
by @xgreenx in #2106
* Remove deadline clock in POA and replace with tokio time functions. by
@AurelienFT in #2109

## New Contributors
* @mmyyrroonn made their first contribution in
#2072

**Full Changelog**:
v0.33.0...v0.34.0
@arboleya arboleya mentioned this pull request Aug 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchTurner MitchTurner MitchTurner approved these changes

@Dentosal Dentosal Dentosal approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a GraphQL endpoint to fetch the blob byte code by its ID
4 participants
@netrome @Dentosal @MitchTurner @xgreenx