Linking TxPoolV2 in place of V1 #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # crates/services/txpool/src/transaction_selector.rs # crates/services/txpool/src/txpool.rs # crates/services/txpool_v2/Cargo.toml # crates/services/txpool_v2/src/config.rs # crates/services/txpool_v2/src/lib.rs # crates/services/txpool_v2/src/pool.rs # crates/services/txpool_v2/src/ports.rs # crates/services/txpool_v2/src/selection_algorithms/mod.rs # crates/services/txpool_v2/src/selection_algorithms/ratio_tip_gas.rs # crates/services/txpool_v2/src/service.rs # crates/services/txpool_v2/src/service/subscriptions.rs # crates/services/txpool_v2/src/service/verifications.rs # crates/services/txpool_v2/src/shared_state.rs # crates/services/txpool_v2/src/tests/stability_test.rs # crates/services/txpool_v2/src/tests/tests_p2p.rs # crates/services/txpool_v2/src/tests/tests_pool.rs # crates/services/txpool_v2/src/tests/tests_service.rs # crates/services/txpool_v2/src/tx_status_stream.rs
…blocks in Instant mode
xgreenx
approved these changes
Oct 8, 2024
rymnc
approved these changes
Oct 8, 2024
This was referenced Oct 8, 2024
Closed
Merged
xgreenx
added a commit
that referenced
this pull request
Oct 8, 2024
## Version v0.38.0 ### Added - [2309](#2309): Limit number of concurrent queries to the graphql service. - [2216](#2216): Add more function to the state and task of TxPoolV2 to handle the future interactions with others modules (PoA, BlockProducer, BlockImporter and P2P). - [2263](#2263): Use the Txpool v2 in the whole codebase. ### Removed - [2306](#2306): Removed hack for genesis asset contract from the code. ## What's Changed * Updates to price algorithm by @rafal-ch in #2292 * Removed hack from the code by @xgreenx in #2306 * fix(p2p): useless dials to reserved nodes which dont have a location multiaddress by @rymnc in #2308 * Txpool v2 features for futures connections with other modules by @AurelienFT in #2216 * Limit number of concurrent queries to the graphql service by @netrome in #2309 * Linking TxPoolV2 in place of V1 by @AurelienFT in #2263 **Full Changelog**: v0.37.1...v0.38.0 --------- Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2020
Closes #1961
Closes #868
Closes #2185
Closes #2186
Closes #2255
Closes #2160
Closes #1967
Closes #2187
Description
Remove code of the previous txpool and connect all modules to this one
Transaction pool is now included in all modules of the code it has requires modifications on different modules :
- The PoA is now notify only when there is new transaction and not using the
tx_update_senderanymore.- The Pool transaction source for the executor is now locking the pool until the block production is finished.
- Reading operations on the pool is now asynchronous and it’s the less prioritized operation on the Pool, API has been updated accordingly.
- GasPrice is no more using async to allow the transactions verifications to not use async anymore
We also added a lot of new configuration cli parameters to fine-tune TxPool configuration.
This PR also changes the way we are making the heavy work processor and a sync and asynchronous version is available in services folder (usable by anyone)
P2P now use separate heavy work processor for DB and TxPool interactions.
Checklist
Before requesting review