fix(p2p): useless dials to reserved nodes which dont have a location multiaddress #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run fuel-core with |
xgreenx
approved these changes
Oct 7, 2024
AurelienFT
approved these changes
Oct 7, 2024
This was referenced Oct 8, 2024
Merged
xgreenx
added a commit
that referenced
this pull request
Oct 8, 2024
## Version v0.38.0 ### Added - [2309](#2309): Limit number of concurrent queries to the graphql service. - [2216](#2216): Add more function to the state and task of TxPoolV2 to handle the future interactions with others modules (PoA, BlockProducer, BlockImporter and P2P). - [2263](#2263): Use the Txpool v2 in the whole codebase. ### Removed - [2306](#2306): Removed hack for genesis asset contract from the code. ## What's Changed * Updates to price algorithm by @rafal-ch in #2292 * Removed hack from the code by @xgreenx in #2306 * fix(p2p): useless dials to reserved nodes which dont have a location multiaddress by @rymnc in #2308 * Txpool v2 features for futures connections with other modules by @AurelienFT in #2216 * Limit number of concurrent queries to the graphql service by @netrome in #2309 * Linking TxPoolV2 in place of V1 by @AurelienFT in #2263 **Full Changelog**: v0.37.1...v0.38.0 --------- Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Fixes #2298
Description
The reserved nodes that are passed into various behaviours, like gossipsub and discovery, are only used there for whitelisting. If only a
PeerIdis provided with/p2p/prefix, then we should not attempt to dial such a peer since it doesn't have a location multiaddress.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]