Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to price algorithm #2292

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Updates to price algorithm #2292

merged 4 commits into from
Oct 7, 2024

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Oct 4, 2024

Description

This PR changes a couple of minor things w.r.t to price algorithm.

  1. It changes the order of operations in recalculate_projected_cost() so it uses a single multiplication
  2. Replaces sum() with fold()+saturating_add()
  3. Minor renames for clarity

Before requesting review

  • I have reviewed the code myself

@rafal-ch rafal-ch added the no changelog Skip the CI check of the changelog modification label Oct 4, 2024
@rafal-ch rafal-ch self-assigned this Oct 4, 2024
@rafal-ch rafal-ch requested a review from a team October 4, 2024 15:26
@rafal-ch rafal-ch enabled auto-merge (squash) October 7, 2024 06:08
@rafal-ch rafal-ch merged commit 761ddb4 into master Oct 7, 2024
31 of 32 checks passed
@rafal-ch rafal-ch deleted the updates_to_price_algorithm branch October 7, 2024 06:37
@xgreenx xgreenx mentioned this pull request Oct 8, 2024
xgreenx added a commit that referenced this pull request Oct 8, 2024
## Version v0.38.0

### Added
- [2309](#2309): Limit number
of concurrent queries to the graphql service.
- [2216](#2216): Add more
function to the state and task of TxPoolV2 to handle the future
interactions with others modules (PoA, BlockProducer, BlockImporter and
P2P).
- [2263](#2263): Use the
Txpool v2 in the whole codebase.

### Removed
- [2306](#2306): Removed hack
for genesis asset contract from the code.

## What's Changed
* Updates to price algorithm by @rafal-ch in
#2292
* Removed hack from the code by @xgreenx in
#2306
* fix(p2p): useless dials to reserved nodes which dont have a location
multiaddress by @rymnc in
#2308
* Txpool v2 features for futures connections with other modules by
@AurelienFT in #2216
* Limit number of concurrent queries to the graphql service by @netrome
in #2309
* Linking TxPoolV2 in place of V1 by @AurelienFT in
#2263


**Full Changelog**:
v0.37.1...v0.38.0

---------

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants