Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 0.3.6: default sequence return format changed from FASTA to JSON #999

Closed
corneliusroemer opened this issue Oct 25, 2024 · 2 comments
Closed

Regression in 0.3.6: default sequence return format changed from FASTA to JSON #999

corneliusroemer opened this issue Oct 25, 2024 · 2 comments

Comments

@corneliusroemer
Copy link
Contributor

It looks like the default sequence return format changed from FASTA to JSON in v0.3.6 with PR #983

We noticed this in Loculus when trying to use 0.3.6: loculus-project/loculus#3077 (comment)

          You seem to have replaced all FASTA tests with JSON tests, thereby no longer testing that the FASTA is output correctly and not noticing that the default changed as well.

Originally posted by @corneliusroemer in #983 (comment)
@corneliusroemer
Copy link
Contributor Author

Turns out we actually asked for JSON in the accept header - so that's reasonable behavior

@corneliusroemer corneliusroemer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
corneliusroemer added a commit to loculus-project/loculus that referenced this issue Oct 25, 2024
@corneliusroemer
fix: request FASTA format explicitly for sequences
7ba6c68 
Related to:
- GenSpectrum/LAPIS#999
- GenSpectrum/LAPIS#971
@corneliusroemer
Copy link
Contributor Author

This is the bug that 0.3.6 surfaced, wrong accept header: loculus-project/loculus#3078

anna-parker pushed a commit to loculus-project/loculus that referenced this issue Oct 25, 2024
@corneliusroemer @anna-parker
fix: request FASTA format explicitly for sequences
4beeca2 
Related to:
- GenSpectrum/LAPIS#999
- GenSpectrum/LAPIS#971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corneliusroemer