feat: make it possible to return sequences as json or ndjson #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.3.6 (2024-10-15)Features |
fengelniederhammer
force-pushed
the
971-make-it-possible-to-return-sequences-as-json-or-ndjson
branch
from
c96279c
to
1fe5a71
Compare
fengelniederhammer
force-pushed
the
971-make-it-possible-to-return-sequences-as-json-or-ndjson
branch
from
1fe5a71
to
d6c33cb
Compare
JonasKellerer
approved these changes
Oct 15, 2024
The cache broke the build because something was outdated. I'd rather have ci that runs a little longer than a more complicated build setup to maintain.
fengelniederhammer
force-pushed
the
971-make-it-possible-to-return-sequences-as-json-or-ndjson
branch
from
483aede
to
92510c9
Compare
fengelniederhammer
deleted the
971-make-it-possible-to-return-sequences-as-json-or-ndjson
branch
|
This might have been a breaking change: loculus-project/loculus#3077 (comment) |
There was a problem hiding this comment.
You seem to have replaced all FASTA tests with JSON tests, thereby no longer testing that the FASTA is output correctly and not noticing that the default changed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #971
PR Checklist