-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chore): Update to update to silo 0.3.0, lapis to 0.3.7, fix e2e tests #3077
Conversation
Do we use that field anywhere? It's only in dummy I think? We could also just drop it there, it doesn't serve much purpose. |
I'm quite sure you can just drop the pango lineage field (or make it a regular field - that's maybe even the better option, because there will be fewer changes). |
@fengelniederhammer I tried dropping the type first so making it a regular field - but it seems that SILO sees the name as meaning a pango_lineage - so I got the same error. I didn't want to remove the entire field as I think this will mean having to change all e2e tests. |
No, there is no meaning attached to field names in SILO. The SILO database config should look like:
( |
I just read the error message careful enough: Simply remove |
@fengelniederhammer what does partitionBy do actually? - it looks like it just splits up the table - so why does it have to be a lineage now? |
https://lapis.cov-spectrum.org/open/v2/docs/maintainer-docs/references/database-configuration It also had to be a lineage before. (Before: This provides optimizations:
|
resolves #
preview URL: https://fix-e2e.loculus.org/
Summary
Removee
type: pango_lineage
, also removepartitionBy
option as this is only a lineage-feature (why?)Screenshot
PR Checklist