Update #4
Merged
Update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entgroup_flattenstringset resource/codedeploy_deployment_group: Use flattenStringSet helper
Reference: https://github.com/hashicorp/terraform-provider-scaffolding/blob/3c87a86ff2eeb6b0835e26b16f2bf8bc293622fd/main.go#L22-L38 To match recent updates to the scaffold provider, this allows easier usage of Go debugging tooling, such as delve, via a provider reattachment mode. This is primarily for provider developers and does not affect practitioner usage. Example usage: ```console $ go run . -debug {"@Level":"debug","@message":"plugin address","@timestamp":"2020-12-02T21:23:22.095285-05:00","address":"/var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/plugin326120673","network":"unix"} Provider started, to attach Terraform set the TF_REATTACH_PROVIDERS env var: TF_REATTACH_PROVIDERS='{"registry.terraform.io/hashicorp/aws":{"Protocol":"grpc","Pid":45042,"Test":true,"Addr":{"Network":"unix","String":"/var/folders/w8/05f3x02n27x72g0mc2jy6_180000gp/T/plugin326120673"}}}' ```
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
…ement documentation/bug-template: Add language to indicate that configurations to reproduce bugs are required
…utes docs(lex_bot.html.markdown): updated missing attributes for lex_bot
…n sweeper (hashicorp#16417) Reference: https://aws.amazon.com/premiumsupport/knowledge-center/batch-invalid-compute-environment/ Reference: https://docs.aws.amazon.com/batch/latest/userguide/service_IAM_role.html The Batch API does not support IAM Service-Linked Roles and deleting the associated IAM Role with Batch Compute Environments will leave it permanently in an INVALID status, preventing deletion and causing the sweeper to repeatedly wait until the deletion timeout to move on every run afterwards. To fix the status issue, the IAM Role must be fixed or reassigned before attempting deletion. In this case, we opt to "fix" the IAM Role by recreating it and allow the aws_iam_role sweeper to handle cleanup. Output from sweeper in AWS Commercial (all these were previously INVALID): ``` 2020/11/24 15:53:08 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/24 15:53:08 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-2) 2020/11/24 15:53:09 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2) 2020/11/24 15:53:10 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-2954252320589067561 2020/11/24 15:53:26 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-2954252320589067561 2020/11/24 15:53:33 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-9215922465722138477 2020/11/24 15:53:50 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-9215922465722138477 2020/11/24 15:53:57 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-1607415242139515600 2020/11/24 15:54:14 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-1607415242139515600 2020/11/24 15:54:21 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-5133588329333275430 2020/11/24 15:54:37 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-5133588329333275430 2020/11/24 15:54:44 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-5530827886790132531 2020/11/24 15:55:01 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-5530827886790132531 2020/11/24 15:55:07 Sweeper Tests ran successfully: - aws_batch_job_queue - aws_batch_compute_environment 2020/11/24 15:55:07 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/24 15:55:07 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-east-1) 2020/11/24 15:55:08 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-east-1) 2020/11/24 15:55:09 Sweeper Tests ran successfully: - aws_batch_job_queue - aws_batch_compute_environment ok github.com/terraform-providers/terraform-provider-aws/aws 123.891s ``` Output from sweeper in AWS GovCloud (US) (all these were previously INVALID): ``` 2020/11/24 16:00:27 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/24 16:00:27 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-gov-west-1) 2020/11/24 16:00:29 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-gov-west-1) 2020/11/24 16:00:31 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-7885136928720777256 2020/11/24 16:00:47 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-7885136928720777256 2020/11/24 16:00:55 [DEBUG] Disabling Batch Compute Environment: tf-acc-test-2569001613797177836 2020/11/24 16:01:12 [DEBUG] Deleting Batch Compute Environment: tf-acc-test-2569001613797177836 2020/11/24 16:01:18 Sweeper Tests ran successfully: - aws_batch_job_queue - aws_batch_compute_environment ok github.com/terraform-providers/terraform-provider-aws/aws 53.893s ```
…dardize disappears testing (hashicorp#16304) Reference: hashicorp#16302 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSLightsailDomain_disappears (10.22s) --- PASS: TestAccAWSLightsailDomain_basic (10.27s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSLightsailDomain_basic (1.70s) --- SKIP: TestAccAWSLightsailDomain_disappears (1.70s) ```
tests/r/vpn_gateway: Fix hardcoded region
ds/eip ds/arn: Fix hardcoded region
…al_node-connection_pool-outlier_detection r/aws_appmesh_virtual_node: Add connection pool and outlier detection
…ssions Lake Formation Permissions
…roup-instance_refresh resource/aws_autoscaling_group: Add Instance Refresh configuration
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by Renovate Bot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with upstream
Pull this PR: hashicorp#16087