Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 set current_config in ModData._load_config() #523

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

KANAjetzt
Copy link
Member

Fixed an issue where current_config was null because it wasn't set in ModData._load_config().

closes #466

Fixed an issue where `current_config` was null because it wasn't set in `ModData._load_config()`.

closes GodotModding#466
@KANAjetzt KANAjetzt added bug Something isn't working 3.x labels Jan 25, 2025
@KANAjetzt KANAjetzt added this to the 3.x - v6.3.0 milestone Jan 25, 2025
@KANAjetzt KANAjetzt requested a review from Qubus0 January 25, 2025 10:01
@KANAjetzt KANAjetzt self-assigned this Jan 25, 2025
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for now, just some extra thoughts

addons/mod_loader/resources/mod_data.gd Outdated Show resolved Hide resolved
@KANAjetzt KANAjetzt force-pushed the fix_current_config_null branch from 020c143 to 0038c46 Compare January 26, 2025 16:18
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's nicer

addons/mod_loader/resources/mod_data.gd Show resolved Hide resolved
@KANAjetzt KANAjetzt added this pull request to the merge queue Jan 26, 2025
Merged via the queue into GodotModding:development with commit ee15766 Jan 26, 2025
2 checks passed
KANAjetzt added a commit that referenced this pull request Jan 26, 2025
* fix: 🐛 set `current_config` in `ModData._load_config()`

Fixed an issue where `current_config` was null because it wasn't set in `ModData._load_config()`.

closes #466

* fix: 🐛 added method to check if user profiles are initialized

* fix: 🐛 `current_config` = default if no user profile
@KANAjetzt KANAjetzt mentioned this pull request Jan 26, 2025
KANAjetzt added a commit that referenced this pull request Jan 27, 2025
# Minor Release v6.3.0

Minor update to fix issues with script extension sorting, as well as
potential issues with translations, configurations, and user profiles.

## Key PRs
- #357
- #358
- #520
- #352

## Change Log

### New Features

- #352
- #358

### Fixes
- #357
- #520 
- #522 
- #523
- #524

### Refactors
- #521
- #526

### Tests
- #360 

### Miscellaneous
- #525
- #527
- #529
@KANAjetzt KANAjetzt deleted the fix_current_config_null branch January 28, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants