-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 set current_config
in ModData._load_config()
#523
Merged
KANAjetzt
merged 3 commits into
GodotModding:development
from
KANAjetzt:fix_current_config_null
Jan 26, 2025
Merged
fix: 🐛 set current_config
in ModData._load_config()
#523
KANAjetzt
merged 3 commits into
GodotModding:development
from
KANAjetzt:fix_current_config_null
Jan 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where `current_config` was null because it wasn't set in `ModData._load_config()`. closes GodotModding#466
Qubus0
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for now, just some extra thoughts
KANAjetzt
force-pushed
the
fix_current_config_null
branch
from
January 26, 2025 16:18
020c143
to
0038c46
Compare
Qubus0
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's nicer
KANAjetzt
added a commit
that referenced
this pull request
Jan 26, 2025
* fix: 🐛 set `current_config` in `ModData._load_config()` Fixed an issue where `current_config` was null because it wasn't set in `ModData._load_config()`. closes #466 * fix: 🐛 added method to check if user profiles are initialized * fix: 🐛 `current_config` = default if no user profile
Merged
KANAjetzt
added a commit
that referenced
this pull request
Jan 27, 2025
# Minor Release v6.3.0 Minor update to fix issues with script extension sorting, as well as potential issues with translations, configurations, and user profiles. ## Key PRs - #357 - #358 - #520 - #352 ## Change Log ### New Features - #352 - #358 ### Fixes - #357 - #520 - #522 - #523 - #524 ### Refactors - #521 - #526 ### Tests - #360 ### Miscellaneous - #525 - #527 - #529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where
current_config
was null because it wasn't set inModData._load_config()
.closes #466