-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.3.0 #528
Merged
Merged
v6.3.0 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: log name wildcards * refactor: use trim_suffix instead of replace * fix: bad rename
* added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir
* test: ✅ initial test environment * test: ✅ initial test environment * ci: 🚧 WIP: GitHub Actions * ci: 🚧 WIP: Adding GitHub Action for Tests * refactor: ♻️ ignore `.import` * ci: ✨ Working Test Action * fix: 🐛 fixed missing default * ci: ♻️ run action on push and pr * fix: 🐛 fixed indentation * fix: 🐛 added missing `shell` prop * fix: 🐛 fixed `godot-bin` input * ci: ♻️ moved test run script into `.sh` file * fix: 🐛 fix `Permission denied` fix: 🐛 fix `Permission denied` fix: 🐛 fix `Permission denied` fix: 🐛 fix `Permission denied` fix: 🐛 fix `Permission denied` * ci: ♻️ added GUT download step * test: ♻️ removed GUT * test: 🙈 ignore all addons * ci: 🐛 fixed gut download cache * test: 🔥 only run `gut_cmdln.gd` gut returns exit code 1 if a test fails * test: 🔥 removed root dir gut files * fix: 🐛 fixed typo * fix: 🐛 fix godot bin cache
fix: 🐛 fixed missing script parent path (#383) * feat: script extensions sorter checks load order (#357) * added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir * fix: 🐛 fixed missing script parent path Before, if the same script was extended multiple times, the `parent_script_path` would be empty for all extensions except the first one. * fix: ✏️ removed no longer accurate comment
and spacing style changes closes #389
ci: ➖ removed PR dependency check (#510)
* fix: 🐛 set `current_config` in `ModData._load_config()` Fixed an issue where `current_config` was null because it wasn't set in `ModData._load_config()`. closes #466 * fix: 🐛 added method to check if user profiles are initialized * fix: 🐛 `current_config` = default if no user profile
* Added method to rename user profile * Corrected functional changes and indentation from review * Indentation * Corrected false indentation and error * Corrected false indentation and error * Updated some failed changes * refactor: ♻️ export props only exported properties are duplicated * refactor: 🔥 remove vars * fix: 🐛 wrong user_profiles ref --------- Co-authored-by: Kai <kai@kana.jetzt>
07a065c
to
9879256
Compare
* docs: Update README.md * docs: 📝 more supported godot version info * docs: 📝 move Discord info below Compatibility * docs: 📝 added Releases section
Qubus0
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot 3.x - Minor Release v6.3.0
Minor update to fix issues with script extension sorting, as well as potential issues with translations, configurations, and user profiles.
Installation
Godot Project Setup
Mod Loader Self Setup
Key PRs
rename_profile()
toModLoaderUserProfile
#352Change Log
New Features
rename_profile()
toModLoaderUserProfile
#352Fixes
current_config
inModData._load_config()
#523Refactors
unpacked_dir
var #521get_data()
#526Tests
Miscellaneous
New Contributors
rename_profile()
toModLoaderUserProfile
#352