Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some fields in artifact config and kustomize config. #1065

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 29, 2018

No description provided.

Fixes GoogleContainerTools#247

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1032

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #1065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   40.86%   40.86%           
=======================================
  Files          70       70           
  Lines        3091     3091           
=======================================
  Hits         1263     1263           
  Misses       1703     1703           
  Partials      125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600f25b...0be3f96. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit a6a874e into GoogleContainerTools:master Oct 2, 2018
@dgageot dgageot deleted the rename-config branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants