Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guake multi-monitor placement / unity dock width subtraction in monitor without dock #422

Open
xfenix opened this issue Nov 27, 2014 · 11 comments

Comments

@xfenix
Copy link

xfenix commented Nov 27, 2014

Hi, first of all, thank you for your great terminal!

screenshot from 2014-11-27 19 39 01

Probably, this is another problem with multi-monitor case.
I am place dock only for second, right monitor, and disable it for first, left (i attached a screenshot).
But, how you can see, guake anyway subtract 64 pixels from width.
I can "fix" this if replace if unity_hide != 1 with if False: (and file guake_app.py probably, not guake.py). But, this is dirty, stupid, works only for me and only for this case.
Probably, there can be simpler solution (or im miss something). Or, if not, than, will be so cool, if you can add some option to avoid this problem in future releases.
Thanks!

"Fixed" problem:
screenshot from 2014-11-27 20 14 57

@gsemet
Copy link
Member

gsemet commented Nov 27, 2014

Look pretty simple. If in unity environment, but if NOT on the screen where there is the dock, so do not substract 64 pixels.

@alexwhitman
Copy link

I wouldn't hard code it to 64 pixels as the launcher size can be changed. Instead you should look at /org/compiz/profiles/unity/plugins/expo/x-offset.

@gsemet
Copy link
Member

gsemet commented Dec 9, 2014

Agree

@gsemet
Copy link
Member

gsemet commented Apr 18, 2015

is it still applicable?

@cromulentbanana
Copy link

Greetings. I am experiencing a similar problem (observed both in version 0.5.0 and version 0.7.0) where the width of the guake window does not extend across the entire screen. In my situation, however I have only one monitor in use. As illustrated in the screenshot, observe the gap between the edge of the guake window and the right-hand side of the screen.

image

P.S. Thanks for Guake :-)

@vizzard
Copy link

vizzard commented Jun 19, 2015

Changing guake-0.7.2/src/guake/guake_app.py line 871:
window_rect.width = window_rect.width - unity_dock
like this by removing "- unity_dock":
window_rect.width = window_rect.width
and running 'dev.sh --reinstall' and 'dev.sh --install' fixed issue for me.
Looks like 'window_rect.width' already has correct value because guake is full width when launcher is hidden and when launcher is visible it also has correct size (100% screen width minus launcher width). It's working even with different launcher size set (both smaller and larger than default).

@gsemet gsemet modified the milestones: 0.8.1, 0.8.2 Aug 18, 2015
@gsemet gsemet modified the milestones: 0.8.2, 0.8.3 Oct 25, 2015
@gsemet gsemet modified the milestones: 0.8.4, 0.8.5 Feb 29, 2016
@gsemet gsemet removed this from the 0.8.4 milestone Feb 29, 2016
@gsemet gsemet modified the milestones: 0.8.5, 0.8.6 Jun 6, 2016
@gsemet gsemet modified the milestones: 0.8.6, 0.8.7 Aug 20, 2016
@gsemet gsemet modified the milestones: 0.8.8, 0.8.9 Dec 13, 2016
brandoncurtis added a commit to brandoncurtis/guake that referenced this issue Jan 17, 2017
Addresses Guake#422, Guake#522, Guake#565 when Unity dock is used on the bottom of the screen by adding a check for the dock's position; if the dock isn't positioned "Left" or "Right", don't modify Guake's width to account for the Unity dock's width.
brandoncurtis added a commit to brandoncurtis/guake that referenced this issue Jan 22, 2017
Addresses Guake#422, Guake#522, Guake#565 when Unity dock is used on the bottom of the screen by adding a check for the dock's position; if the dock isn't positioned "Left" or "Right", don't modify Guake's width to account for the Unity dock's width.
@gsemet gsemet modified the milestones: 0.8.9, 0.8.11 Jun 28, 2017
@gsemet gsemet removed this from the 0.8.11 milestone Jan 11, 2018
@tchaffee
Copy link

I have the opposite problem on Gnome 3.28 with Wayland. On my primary monitor, Guake extends too far and goes into the 2nd monitor. By exactly the width of the dock / dash. On my 2nd monitor without the dash, it is the right width. On my 3rd monitor which has a different resolution, Guake is way too big and extends back on to the primary monitor. It seems like it is not re-calculating width based on the current monitor and also accounting for the dock if present.

@kpalczewski
Copy link

It seems like this is the same issue as #1350

@gsemet
Copy link
Member

gsemet commented Apr 17, 2020

Sadly, i have no way of testig it. I would welcome a lot a pull request !

@Davidy22
Copy link
Collaborator

A patch #1765 that may fix this has just been merged. Can you confirm whether or not this is fixed in the current git main? If you can't compile, updates when the next version is released are also welcome.

@kpalczewski
Copy link

I have commented in #1765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants