Fix window width with Unity #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
look good. Please execute ./validate.sh to have autopep8 fix your code style |
|
Merged ! |
|
I think validate.sh was run on an older base as that commit has reverted the last few commits and guake no longer runs. |
|
@tombriden, correct, I messed up and forgot I checked out v0.8.8. Opened a PR to revert, then I'll redo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #422, #522, #565 when Unity dock is used on the bottom of the screen by adding a check for the dock's position; modify Guake's width to account for the Unity dock's width iff the dock is positioned "Left" or "Right".