Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap on the right in Ubuntu 15.04 #522

Closed
Suor opened this issue May 5, 2015 · 3 comments
Closed

Gap on the right in Ubuntu 15.04 #522

Suor opened this issue May 5, 2015 · 3 comments

Comments

@Suor
Copy link

Suor commented May 5, 2015

I just updated to Ubuntu 15.04, Guake 0.5 and now I have a gap on the right, although guake width is set to 100%. If I set align right the gap persists, so it's not the incorrect width bug.
guake-gap

@Suor
Copy link
Author

Suor commented May 5, 2015

Updated to 0.7, and this is fixed there. Closing, sorry.

@vizzard
Copy link

vizzard commented Jun 19, 2015

I don't believe it's fixed. I have this on Ubuntu 15.04 with Guake 0.7.2 (laptop with one screen).
Changing guake-0.7.2/src/guake/guake_app.py line 871:
window_rect.width = window_rect.width - unity_dock
like this by removing "- unity_dock":
window_rect.width = window_rect.width
and running 'dev.sh --reinstall' and 'dev.sh --install' fixed issue for me.
Looks like 'window_rect.width' already has correct value because guake is full width when launcher is hidden and when launcher is visible it also has correct size (100% screen width minus launcher width). It's working even with different launcher size set (both smaller and larger than default).

@gsemet gsemet reopened this Jun 21, 2015
brandoncurtis added a commit to brandoncurtis/guake that referenced this issue Jan 17, 2017
Addresses Guake#422, Guake#522, Guake#565 when Unity dock is used on the bottom of the screen by adding a check for the dock's position; if the dock isn't positioned "Left" or "Right", don't modify Guake's width to account for the Unity dock's width.
brandoncurtis added a commit to brandoncurtis/guake that referenced this issue Jan 22, 2017
Addresses Guake#422, Guake#522, Guake#565 when Unity dock is used on the bottom of the screen by adding a check for the dock's position; if the dock isn't positioned "Left" or "Right", don't modify Guake's width to account for the Unity dock's width.
@Davidy22
Copy link
Collaborator

Fixes merged and original submitter marked resolved, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants