Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Autoconf version to 2.71 #2944

Merged
merged 1 commit into from
May 12, 2023
Merged

Bump Autoconf version to 2.71 #2944

merged 1 commit into from
May 12, 2023

Conversation

derobins
Copy link
Member

Required for building with Intel's oneAPI

@derobins
Bump Autoconf version to 2.71
74c20eb 
Required for building with Intel's oneAPI
@derobins derobins added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality labels May 11, 2023
@derobins
Copy link
Member Author

I feel like we are at the point where we have to merge this in. If we don't, we risk breaking oneAPI unless we are SUPER careful (and I'm not a fan of fragile manual steps).

If anyone has any other ideas about how we can manage the tension between "need to build HDF5 on older machines" and "need to support oneAPI", I'm all ears.

@jhendersonHDF
Copy link
Collaborator

I feel like we are at the point where we have to merge this in. If we don't, we risk breaking oneAPI unless we are SUPER careful (and I'm not a fan of fragile manual steps).

If anyone has any other ideas about how we can manage the tension between "need to build HDF5 on older machines" and "need to support oneAPI", I'm all ears.

Considering that Slackware moved to 2.71 back in Feb. of last year, I think it's a safe bet at this point that most others will have moved along too.

brtnfld
brtnfld approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus, if a user really wants to regenerate using 2.69, it is a one-line change since there are no 2.71 nuances.

Although, a search on GitHub reported ~12k using 2.69 compared to 760 using 2.71

@hyoklee
Copy link
Member

hyoklee commented May 11, 2023

Where is oneAPI Action to test?

@derobins
Copy link
Member Author

Where is oneAPI Action to test?

That's going to take some time to set up, but it's on the agenda. One thing at a time.

@derobins derobins merged commit 2a2c2d9 into HDFGroup:develop May 12, 2023
@hyoklee
Copy link
Member

hyoklee commented May 12, 2023

configure fails with --enable-parallel.

@hyoklee hyoklee mentioned this pull request May 12, 2023
Closed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@derobins @brtnfld
Bump Autoconf version to 2.71 (HDFGroup#2944)
a083d04 
Required for building with Intel's oneAPI
derobins added a commit to derobins/hdf5 that referenced this pull request Jun 6, 2023
@derobins
Bring key changesets from develop
0c34a92 
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015)
* Bump Autoconf version to 2.71 (HDFGroup#2944)
* Fix missing h5_reset() calls in accum test (HDFGroup#3001)
* Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777)
* Fix Java debug asserts on Windows (HDFGroup#3012)
* Fix long double dt_arith bug on macOS (HDFGroup#3038)
@derobins derobins mentioned this pull request Jun 6, 2023
Merged
derobins added a commit that referenced this pull request Jun 6, 2023
@derobins
Bring key changesets from develop (#3052)
4c57a5b 
* Bump GitHub action macOS version to 13 (#2999, #3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (#3015)
* Bump Autoconf version to 2.71 (#2944)
* Fix missing h5_reset() calls in accum test (#3001)
* Only run ttsafe in GitHub thread-safe actions (#2777)
* Fix Java debug asserts on Windows (#3012)
* Fix long double dt_arith bug on macOS (#3038)
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 5, 2023
@derobins @brtnfld
Bring key changesets from develop (HDFGroup#3052)
bece7c1 
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015)
* Bump Autoconf version to 2.71 (HDFGroup#2944)
* Fix missing h5_reset() calls in accum test (HDFGroup#3001)
* Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777)
* Fix Java debug asserts on Windows (HDFGroup#3012)
* Fix long double dt_arith bug on macOS (HDFGroup#3038)
@derobins derobins deleted the autoconf_2_71 branch March 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@brtnfld brtnfld brtnfld approved these changes

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees

@hyoklee hyoklee

@qkoziol qkoziol

@brtnfld brtnfld

@lrknox lrknox

@jhendersonHDF jhendersonHDF

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@derobins @jhendersonHDF @hyoklee @qkoziol @brtnfld @byrnHDF @lrknox