Add casts to type conversion to fix long dbl bug #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user buffer is misaligned in the type conversion code, memcpy could fail if the call is SSE-optimized by the compiler. This change adds uint8_t * casts so the compiler won't make optimistic assumptions about buffer alignment.
derobins
added
Merge - To 1.12
Priority - 1. High 🔼
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
This only showed up in a different PR (#2382) where we replace the library re-implementation of memcpy with the one in the standard library, but in the past we've frequently had bugs with long doubles that were "fixed" by selecting lower optimization levels for that platform. In the case I tripped over, the problem only shows up at high optimization levels, where the compiler uses SSE to perform the memcpy (SSE buffers have to be aligned on 16 bytes). |
qkoziol
approved these changes
Jun 3, 2023
derobins
added a commit
to derobins/hdf5
that referenced
this pull request
Jun 6, 2023
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009) * Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015) * Bump Autoconf version to 2.71 (HDFGroup#2944) * Fix missing h5_reset() calls in accum test (HDFGroup#3001) * Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777) * Fix Java debug asserts on Windows (HDFGroup#3012) * Fix long double dt_arith bug on macOS (HDFGroup#3038)
derobins
added a commit
that referenced
this pull request
Jun 6, 2023
* Bump GitHub action macOS version to 13 (#2999, #3009) * Bump GitHub action gcc/g++/gfortran version to 12 (#3015) * Bump Autoconf version to 2.71 (#2944) * Fix missing h5_reset() calls in accum test (#3001) * Only run ttsafe in GitHub thread-safe actions (#2777) * Fix Java debug asserts on Windows (#3012) * Fix long double dt_arith bug on macOS (#3038)
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 5, 2023
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009) * Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015) * Bump Autoconf version to 2.71 (HDFGroup#2944) * Fix missing h5_reset() calls in accum test (HDFGroup#3001) * Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777) * Fix Java debug asserts on Windows (HDFGroup#3012) * Fix long double dt_arith bug on macOS (HDFGroup#3038)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user buffer is misaligned in the type conversion code, memcpy could fail if the call is SSE-optimized by the compiler. This change adds uint8_t * casts so the compiler won't make optimistic assumptions about buffer alignment.