Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub macOS actions to v13 #2999

Merged
merged 8 commits into from
May 24, 2023
Merged

Update GitHub macOS actions to v13 #2999

merged 8 commits into from
May 24, 2023

Conversation

derobins
Copy link
Member

@derobins derobins commented May 23, 2023 •
edited
Loading

Fixes #2994
Fixes #1289
Fixes #2261

@derobins derobins added Merge - To 1.12 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels May 23, 2023
brtnfld
brtnfld approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrknox
Copy link
Collaborator

lrknox commented May 23, 2023

Specific test failure:
19: Testing SWMR write of large metadata: with latest format FAILED
19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2291 in test_swmr_write_big()...
19: child process exited abnormally
19: Testing SWMR write of large metadata: with non-latest-format FAILED
19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2291 in test_swmr_write_big()...
19: child process exited abnormally
19: *** TESTS FAILED ***

@derobins
Copy link
Member Author

Specific test failure: 19: Testing SWMR write of large metadata: with latest format FAILED 19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2291 in test_swmr_write_big()... 19: child process exited abnormally 19: Testing SWMR write of large metadata: with non-latest-format FAILED 19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2291 in test_swmr_write_big()... 19: child process exited abnormally 19: *** TESTS FAILED ***

I'm looking into it. The test is fine when run directly and only fails when run via CTest. Autotools is also fine. It's weird that there's a change when going from macOS 11 to 13.

@derobins derobins changed the title Update macOS to 13 Update GitHub macOS actions to v13 May 24, 2023
@derobins
Copy link
Member Author

There are other places where LD_LIBRARY_PATH is used that probably need updating, but that's getting out of scope for this PR...

@derobins derobins merged commit 37e0484 into HDFGroup:develop May 24, 2023
@derobins derobins mentioned this pull request May 24, 2023
Closed
@hyoklee hyoklee mentioned this pull request May 25, 2023
Closed
4 tasks
derobins added a commit to derobins/hdf5 that referenced this pull request May 25, 2023
@derobins
Add release note for HDFGroup#2999
547dbef
derobins added a commit that referenced this pull request May 25, 2023
@derobins
Add release note for #2999 (#3009)
b50225e
derobins added a commit to derobins/hdf5 that referenced this pull request Jun 6, 2023
@derobins
Bring key changesets from develop
0c34a92 
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015)
* Bump Autoconf version to 2.71 (HDFGroup#2944)
* Fix missing h5_reset() calls in accum test (HDFGroup#3001)
* Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777)
* Fix Java debug asserts on Windows (HDFGroup#3012)
* Fix long double dt_arith bug on macOS (HDFGroup#3038)
@derobins derobins mentioned this pull request Jun 6, 2023
Merged
derobins added a commit that referenced this pull request Jun 6, 2023
@derobins
Bring key changesets from develop (#3052)
4c57a5b 
* Bump GitHub action macOS version to 13 (#2999, #3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (#3015)
* Bump Autoconf version to 2.71 (#2944)
* Fix missing h5_reset() calls in accum test (#3001)
* Only run ttsafe in GitHub thread-safe actions (#2777)
* Fix Java debug asserts on Windows (#3012)
* Fix long double dt_arith bug on macOS (#3038)
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 5, 2023
@derobins @brtnfld
Bring key changesets from develop (HDFGroup#3052)
bece7c1 
* Bump GitHub action macOS version to 13 (HDFGroup#2999, HDFGroup#3009)
* Bump GitHub action gcc/g++/gfortran version to 12 (HDFGroup#3015)
* Bump Autoconf version to 2.71 (HDFGroup#2944)
* Fix missing h5_reset() calls in accum test (HDFGroup#3001)
* Only run ttsafe in GitHub thread-safe actions (HDFGroup#2777)
* Fix Java debug asserts on Windows (HDFGroup#3012)
* Fix long double dt_arith bug on macOS (HDFGroup#3038)
@derobins derobins deleted the update_macos_action_13 branch March 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@brtnfld brtnfld brtnfld approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

Assignees
No one assigned
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
4 participants
@derobins @lrknox @brtnfld @byrnHDF