Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer 1.24.8 + break circular dependency between gstreamer and libnice #171902

Merged
merged 6 commits into from
Sep 23, 2024
Merged

gstreamer 1.24.8 + break circular dependency between gstreamer and libnice #171902

merged 6 commits into from
Sep 23, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 16, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Also, break circular dependency between gstreamer and libnice

See Homebrew/discussions#3740, in particular, https://github.com/orgs/Homebrew/discussions/3740#discussioncomment-8566223.

  • gstreamer 1.24.8
  • libnice: disable gstreamer plugin
  • libnice-gstreamer 1.22 (new formula)

@carlocab carlocab added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label May 16, 2024
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core long build Set a long timeout for formula testing labels May 16, 2024
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 16, 2024
@carlocab carlocab force-pushed the gstreamer-libnice branch from cc60a20 to b692485 Compare May 16, 2024 17:42
@carlocab carlocab force-pushed the gstreamer-libnice branch from b692485 to 5aa831f Compare May 17, 2024 03:04
@carlocab carlocab added CI-linux-self-hosted Build on Linux self-hosted runner and removed CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels May 17, 2024
@carlocab carlocab force-pushed the gstreamer-libnice branch 2 times, most recently from 2f8ee2a to d81b906 Compare May 17, 2024 17:30
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 17, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label May 17, 2024
@carlocab carlocab force-pushed the gstreamer-libnice branch from d81b906 to 493b545 Compare May 18, 2024 03:13
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 18, 2024
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed automerge-skip `brew pr-automerge` will skip this pull request labels May 18, 2024
@carlocab carlocab force-pushed the gstreamer-libnice branch from 493b545 to c031af2 Compare May 18, 2024 05:29
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 18, 2024
@carlocab carlocab force-pushed the gstreamer-libnice branch 2 times, most recently from 788928e to 547e259 Compare May 18, 2024 12:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 8, 2024
@davydog187
Copy link

Would love to see this merged! ❤️

@carlocab
Copy link
Member Author

Will get back to this soon.

@carlocab carlocab removed the stale No recent activity label Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 6, 2024
@github-actions github-actions bot closed this Jul 14, 2024
@carlocab carlocab added maintainer feedback Additional maintainers' opinions may be needed and removed upstream issue An upstream issue report is needed labels Sep 22, 2024
@carlocab
gstreamer 1.24.8
d9dc94f 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@carlocab
libnice: disable gstreamer plugin
2a4e309 
This will allow us to build `gstreamer` with `libnice` as a dependency.

Also, add `gettext` dependency on macOS, since this has indirect linkage
to it.
@carlocab
libnice-gstreamer 1.22 (new formula)
4b278a6 
This installs only the GStreamer plugin for libnice.
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 22, 2024
@carlocab carlocab added ready to merge PR can be merged once CI is green CI-no-bottle-cache Disable bottle cache CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Sep 23, 2024
@carlocab carlocab requested a review from a team September 23, 2024 18:32
@carlocab
Copy link
Member Author

Summary for @Homebrew/core:

This implements a feature multiple users (and upstream) have asked for, which we broke recently when we merged the various gst-* formulae to fix various user issues (#125996). See #183884, #161361, #25649, #25680.

The problem is that there is a circular dependency between libnice and gstreamer. We break this by splitting libnice into two: the parts that gstreamer depends on (retained as libnice), and the parts that depend on gstreamer (added as a new formula named libnice-gstreamer).

Splitting libnice requires patching. The patch is provided by a GStreamer maintainer (@nirbheek), and upstreamed at https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/271.

@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request and removed CI-no-bottle-cache Disable bottle cache labels Sep 23, 2024
@p-linnane p-linnane removed automerge-skip `brew pr-automerge` will skip this pull request maintainer feedback Additional maintainers' opinions may be needed labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @p-linnane has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 23, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit 6923326 Sep 23, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the gstreamer-libnice branch September 23, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirbheek nirbheek nirbheek left review comments

@iMichka iMichka iMichka approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@carlocab @davydog187 @AlexHayton @nirbheek @amyspark @iMichka @p-linnane @BrewTestBot