Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethercat master abstraction #97

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Ethercat master abstraction #97

wants to merge 39 commits into from

Conversation

yguel
Copy link
Contributor

@yguel yguel commented Dec 20, 2023

Create master abstraction to enable seemless using of different ethercat masters (e.g. etherlab, SOEM).

Copy link

github-actions bot commented Dec 20, 2023

Test Results

186 tests  +59   152 ✔️ +47   0s ⏱️ ±0s
  44 suites +15     34 💤 +12 
  44 files   +15       0 ±  0 

Results for commit b8eaa12. ± Comparison against base commit 396cb1a.

This pull request removes 10 and adds 69 tests. Note that renamed tests count towards both.
ethercat_generic_cia402_drive.EcCiA402DriveTest ‑ SlaveSetupDomains
ethercat_generic_cia402_drive.EcCiA402DriveTest ‑ SlaveSetupPdoChannels
ethercat_generic_cia402_drive.EcCiA402DriveTest ‑ SlaveSetupSyncs
ethercat_generic_slave.GenericEcSlaveTest ‑ SlaveSetupDomains
ethercat_generic_slave.GenericEcSlaveTest ‑ SlaveSetupPdoChannels
ethercat_generic_slave.GenericEcSlaveTest ‑ SlaveSetupSyncs
ethercat_interface.copyright ‑ src/ec_master.cpp
ethercat_interface.cppcheck ‑ src/ec_master.cpp
ethercat_interface.cpplint ‑ /ros/src/ethercat_driver_ros2/ethercat_interface/src/ec_master.cpp
ethercat_interface.uncrustify ‑ src/ec_master.cpp
ethercat_interface.copyright ‑ include/ethercat_interface/ec_buffer_tools.h
ethercat_interface.cppcheck ‑ include/ethercat_interface/ec_buffer_tools.h
ethercat_interface.cpplint ‑ /ros/src/ethercat_driver_ros2/ethercat_interface/include/ethercat_interface/ec_buffer_tools.h
ethercat_interface.uncrustify ‑ include/ethercat_interface/ec_buffer_tools.h
ethercat_master_etherlab.EtherlabSlaveTest ‑ EcReadTPDOToStateInterface
ethercat_master_etherlab.EtherlabSlaveTest ‑ EcWriteRPDODefaultValue
ethercat_master_etherlab.EtherlabSlaveTest ‑ EcWriteRPDOFromCommandInterface
ethercat_master_etherlab.EtherlabSlaveTest ‑ SlaveSetup
ethercat_master_etherlab.EtherlabSlaveTest ‑ SlaveSetupDomains
ethercat_master_etherlab.EtherlabSlaveTest ‑ SlaveSetupPdoChannels
…
This pull request removes 1 skipped test and adds 13 skipped tests. Note that renamed tests count towards both.
ethercat_interface.cppcheck ‑ src/ec_master.cpp
ethercat_interface.cppcheck ‑ include/ethercat_interface/ec_buffer_tools.h
ethercat_master_etherlab.cppcheck ‑ include/ethercat_master/ec_master_etherlab.hpp
ethercat_master_etherlab.cppcheck ‑ include/ethercat_master/ec_slave_etherlab.hpp
ethercat_master_etherlab.cppcheck ‑ src/ec_master_etherlab.cpp
ethercat_master_etherlab.cppcheck ‑ src/ec_slave_etherlab.cpp
ethercat_master_etherlab.cppcheck ‑ test/test_etherlab_slave.cpp
ethercat_master_etherlab.cppcheck ‑ test/test_etherlab_slave.hpp
ethercat_master_etherlab.cppcheck ‑ test/test_load_ec_master_etherlab.cpp
ethercat_master_mock.cppcheck ‑ include/ethercat_master/ec_master_mock.hpp
ethercat_master_mock.cppcheck ‑ include/ethercat_master/ec_slave_mock.hpp
…

♻️ This comment has been updated with latest results.

@yguel yguel force-pushed the yguel-master-plugin branch from ac813f7 to b8eaa12 Compare December 20, 2023 14:20
Copy link
Member

@mcbed mcbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK, extensive hardware tests required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants