-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTRL+w should close database #2
Comments
This sometimes works. Seems to be a focus issue. When an entry editor is focused, CTRL+w does not work. If the entry table is focused, CTRL+w works. |
When this is fixed, a test should be added, because of regressions. This depends on JabRef#507. |
I tested it really quick and it seemed to work! |
Result: nothing happens. Did you also try that? |
Yep, for me it works. |
Also when at the search field is focused? |
I reset the keybindings and it does neither work in the entry editor, nor in the web search input field, nor in the search. Could you try to check it on a Windows machine? |
Now, it works here too. |
f78c707 Update Turabian (full note) for 17.1.3.2 Reprint Editions (JabRef#5809) 2169ddc Create art-libraries-society-of-north-america-arlisna-reviews.csl (JabRef#5791) 94119a6 Create university-of-south-wales-harvard.csl (JabRef#5787) 470925c Update fachhochschule-sudwestfalen.csl (JabRef#5811) 1a9eff7 Create annals-of-public-and-cooperative-economics.csl (JabRef#5747) d7477f2 Merge pull request JabRef#5368 from POBrien333/patch-862 113e683 Merge pull request JabRef#5812 from citation-style-language/apa-no-initials 62dacff Create universitat-oberta-de-catalunya-apa.csl 046482c Fix Organization Studies title 1213b95 Make oranization-studies dependent c9641f4 Create apa-no-initials.csl 0b4e047 Modify american-journal-of-archaeology.csl (JabRef#5719) ddeda4f Create journal-of-economic-impact.csl (JabRef#5707) 40c2696 Update gallia.csl (JabRef#5782) 5d5927a Create serbian-archives-of-medicine.csl (JabRef#5721) 2777954 Merge pull request JabRef#5807 from dhacker29/master 77e3fca Update Society of Biblical Literature Full Note for 6.1.6 4479a5a haaga-helia-university-of-applied-sciences-harvard.csl: no date cites need to be unique (JabRef#5726) d00e046 Create university-of-roehampton-harvard.csl (JabRef#5732) e76da40 Medicinski Razgledi -- fix locale 75b1554 Add original-date extra to proper place as per SBL Handbook 6.2.17-18 (JabRef#5725) d43676e Update harvard-bournemouth-university.csl (JabRef#5667) 0312a39 Create ABNT NBR 6023:2018. UNESP – Faculdade de Engenharia de Guarati… (JabRef#5705) 6585ff9 Create sinergie-italian-journal-of-management.csl (JabRef#5776) a7dc678 Create journal-of-global-health.csl (JabRef#5775) 02080ce Merge pull request JabRef#5800 from citation-style-language/validation-fixes 8b51d85 change s. d. to s.d. in french style for INBO reports (issue #2) (JabRef#5634) 1b4ec09 Create bloomsbury-academic.csl (JabRef#5741) 1f28d87 Create zeithistorische-forschungen.csl (JabRef#5766) bb11942 Remove superfluous 'container' data from wiley-vch-books 06038a7 Remove et-al affixes be96bd8 Remove et-al affixes from bibliotecae-it.csl 03a94e4 Remove more et-al affixes 07d7423 Revert non-et-al changes to universitat-basel-iberomanistik f8e5fd8 Create medicinski-razgledi.csl (JabRef#5789) b4df8ee Create dut-harvard.csl (JabRef#5762) 40855c4 Fix affixes on et-al b4fe9b0 Merge pull request JabRef#5798 from citation-style-language/uris 3dc4aaf URL-encode documentation URLs 408a3a8 fixes citation-style-language/Sheldon#38 42aca5b Update biophysics-and-physicobiology.csl (JabRef#5751) 706bea0 Create universidade-do-porto-faculdade-de-engenharia-chicago-pt.csl (JabRef#5742) 269ff91 Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#5797) 0ba51e7 Update el-profesional-de-la-informacion.csl (JabRef#5785) dac3baf Create arthropod-systematics-and-phylogeny.csl (JabRef#5772) 9dff241 Merge pull request JabRef#5796 from dhacker29/patch-1 35949f4 Update turabian-fullnote-bibliography-no-ibid.csl ccfb661 Merge pull request JabRef#5793 from benjaminmoon/patch-2 520e127 Update frontiers-medical-journals.csl (JabRef#5740) ab629ab Update natura-croatica.csl (JabRef#5795) 60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl ad4edff Create turabian-fullnote-bibliography-no-ibid d9b956c Update monographs-of-the-palaeontographical-society.csl 3648ae6 Merge pull request JabRef#5792 from StianOby/fix-no-page-number-articles e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl d8778cf Removed "page" (s. ) term for articles that do not have page numbers. 409017c add medium field for eBooks to MLA 8th git-subtree-dir: buildres/csl/csl-styles git-subtree-split: f78c707
Does not work on JabRef 5.7 @Siedlerchr |
…ered from JabRefGUI if proxy requires password
…hentication are enabled, before only auth was checked
(feat) #2 Adds pop-up asking for password at launch.
* Adds feature CleanupJob for removing non-existent files (#2) * feat: RemoveLinksToNotExistentFiles.java * feat: added option to cleanup entries * feat: improved cleanup entry dialogue * Test: implements test for linked files which exist Implementation of a test which calls the cleanup functionality of RemoveLinksToNotExistentFiles with a entry that is linked to an existing file. The test makes sure that no changes are made since the linked file exists. * Refactor: refactored test to match the standard of the project Removed the JavaDoc comment from the test, since other tests in the project don't have JavaDoc:s. Also removed test from the name of the test function, as it seems that the standard way of naming tests is to not have test in the testfunctions name. * Refactor: removed system.out.print() Removed an print from the tests. * fix: non english character deleted * Docs: Added information about changes Added information about the changes made for solving issue#10929 to the CHANGES.md file. --------- * Fix: Removes unused imports and solves other errors Removes unused imports and solves the error of language keys that were not in the english laguage file. * Fix: Removes empty line and solves other issues Removes an empty line where 2 empty lines appear in after each other. Also adds brackets to URL and removes an key which is not in the english language file and was missed in the last commit. * Docs: Removes technicality from changelog Removes technical details for the change made in changelog and also follows the suggestion for removing the space and brackets between the link and the issue. * test: enhanced RemoveLinksToNotExistentFilesTest (#3) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. --------- * Resolve request changes (#4) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. * refactor: replaced .get(0) with .getFirst() for first accessing element of List. Changed was required from ./gradlew rewriteDryRun --------- * Resolve more request changes and warnings (#5) * Reverse the condition and the content in RemoveLinksToNotExistentFiles Resolves comment "Reverse the condition and the content. Reason: You have BOTH (true and false) cases covered. The true case should normally come first." * Fix: Store bibFolder.resolve("test.bib") in a variable * Refactor: Rename variable fileFolder to originalFileFolder and remove comment. * Refactor: Rename defaultFileFolder to newFileFolder * Refactor: Fix indentation in RemoveLinksToNotExistentFilesTest * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Change to use java.nio for file deletion. * Refactor: Move comment to line above. * Refactor: Added "PDF" as third argument to LinkedFile for OnlineLink files * Refactor: Removed unused variables in RemoveLinksToNotExistentFiles * Refactor: Throw IOException in RemoveLinksToNotExistentFilesTest functions * Refactor: Tests assert using List.of() in RemoveLinksToNotExistentFilesTest * Refactor: Corrected Arguments for LinkedFile in RemoveLinksToNotExistentFilesTest * Refactor: Class fields into local variables This refactor fixed 3 warnings. * docs: updated docs to remove merge conflict --------- Co-authored-by: karlsb <36365664+karlsb@users.noreply.github.com> Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
Currently, the database can only be closed by pushing the
x
icon. The usual shortcut CTRL+w should also workThe text was updated successfully, but these errors were encountered: