forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a PDF contains XMP metadata, the found metadata should be shown #5
Comments
4 tasks
Available in JabRef 3.7 thanx to @Braunch |
koppor
pushed a commit
that referenced
this issue
Sep 5, 2020
* feat/#1 Add CSS file type, add button in preferences to import custom CSS file, started on import functionality * feat/#1 Change so that the log messages uses format specifiers instead of string concatenation * feat/#1 Add RadioButton for toggling custom theme * feat/#1 Add preference for setting path to custom CSS theme * feat/#1 Load custom CSS if toggled * feat/#1 Add missing language keys * feat/#1 Remove check if current theme is applied again, check is remove since we don't need it * feat/#1 Save path to custom CSS file in program preferences * Add functionality to let the user import custom CSS file JabRef#5790 * Add CSS file type, add button in preferences to import a custom CSS file, started on import functionality * Change so that the log uses format specifiers instead of string concatenation * Add RadioButton for toggling custom theme * Add preference for setting the path to custom CSS theme * Load custom CSS if toggled * Add missing language keys * Remove check if the current theme is applied again, the check is removed since we don't need it * Save path to the custom CSS file in program preferences * fix/#5 Add checks so that the theme change notification is only shown once, disable custom theme radio button i no custom theme has been imported * Remove added stuff from merge conflict * Add export current theme JabRef#5790 * Add method for saving theme to file * Add modal for selection witch theme to export as CSS * Add missing language lines * Add information about import/export of themes, JabRef#5790 * Fix CodaCy and checkstyle issues, JabRef#5790 * Add fixes from code review, JabRef#5790 * Remove unused import JabRef#5790 * Move the import/export buttons to the Appearance tab JabRef#5790 * Fixed merge errors * Fixed easy remarks * Introduced AppereancePreferences and changed some visual elements * Refactored ExportThemeDialog * Fixed merge error * Removed export theme logic and added validation * CHANGELOG.md * Removed obsolete viewmodel class * Refactored io.File to nio.Path, use of JabRefPreferences and removed vmOption * Refactored ThemeLoader object class to enum with static util methods * Fixed overlooked merge error * Refactored static methods to object methods * Checkstyle Co-authored-by: Nils Streijffert <nils.streijffert@gmail.com> Co-authored-by: Christoph <siedlerkiller@gmail.com>
koppor
pushed a commit
that referenced
this issue
Mar 12, 2024
* Adds feature CleanupJob for removing non-existent files (#2) * feat: RemoveLinksToNotExistentFiles.java * feat: added option to cleanup entries * feat: improved cleanup entry dialogue * Test: implements test for linked files which exist Implementation of a test which calls the cleanup functionality of RemoveLinksToNotExistentFiles with a entry that is linked to an existing file. The test makes sure that no changes are made since the linked file exists. * Refactor: refactored test to match the standard of the project Removed the JavaDoc comment from the test, since other tests in the project don't have JavaDoc:s. Also removed test from the name of the test function, as it seems that the standard way of naming tests is to not have test in the testfunctions name. * Refactor: removed system.out.print() Removed an print from the tests. * fix: non english character deleted * Docs: Added information about changes Added information about the changes made for solving issue#10929 to the CHANGES.md file. --------- * Fix: Removes unused imports and solves other errors Removes unused imports and solves the error of language keys that were not in the english laguage file. * Fix: Removes empty line and solves other issues Removes an empty line where 2 empty lines appear in after each other. Also adds brackets to URL and removes an key which is not in the english language file and was missed in the last commit. * Docs: Removes technicality from changelog Removes technical details for the change made in changelog and also follows the suggestion for removing the space and brackets between the link and the issue. * test: enhanced RemoveLinksToNotExistentFilesTest (#3) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. --------- * Resolve request changes (#4) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. * refactor: replaced .get(0) with .getFirst() for first accessing element of List. Changed was required from ./gradlew rewriteDryRun --------- * Resolve more request changes and warnings (#5) * Reverse the condition and the content in RemoveLinksToNotExistentFiles Resolves comment "Reverse the condition and the content. Reason: You have BOTH (true and false) cases covered. The true case should normally come first." * Fix: Store bibFolder.resolve("test.bib") in a variable * Refactor: Rename variable fileFolder to originalFileFolder and remove comment. * Refactor: Rename defaultFileFolder to newFileFolder * Refactor: Fix indentation in RemoveLinksToNotExistentFilesTest * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Change to use java.nio for file deletion. * Refactor: Move comment to line above. * Refactor: Added "PDF" as third argument to LinkedFile for OnlineLink files * Refactor: Removed unused variables in RemoveLinksToNotExistentFiles * Refactor: Throw IOException in RemoveLinksToNotExistentFilesTest functions * Refactor: Tests assert using List.of() in RemoveLinksToNotExistentFilesTest * Refactor: Corrected Arguments for LinkedFile in RemoveLinksToNotExistentFilesTest * Refactor: Class fields into local variables This refactor fixed 3 warnings. * docs: updated docs to remove merge conflict --------- Co-authored-by: karlsb <36365664+karlsb@users.noreply.github.com> Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
arfazhxss
referenced
this issue
in arfazhxss/jabref
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When dropping a PDF to the "File" field (or the preview panel), sometimes, the popup "XMP metadata found" pops up. The contained data should be shown to help the user to decide what to do.
The text was updated successfully, but these errors were encountered: