-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry based on ISSN number #10124 #10178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into fix-issue-10124
Siedlerchr
reviewed
Aug 15, 2023
src/main/java/org/jabref/logic/importer/fetcher/IssnFetcher.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Aug 17, 2023
src/main/java/org/jabref/logic/importer/fetcher/IssnFetcher.java
Outdated
Show resolved
Hide resolved
… into fix-issue-10124
What is the status here? That code so far looked good |
I was very busy this week but now I'm coming back to deliver this PR this next week! |
* upstream/main: (419 commits) Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Replace "fixes" by "resolves" Change JavaDoc to annotation (JabRef#10571) Fix link (JabRef#10575) Enable collecting GitHub build artifacts for forks (JabRef#10574) Fix file field merging (JabRef#10573) ... # Conflicts: # src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java # src/main/java/org/jabref/logic/importer/WebFetchers.java
* upstream/main: Make generate button wider (JabRef#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (JabRef#10613) ShortDoi
I switched the fetcher to now use the existing Journal Information fetcher and also added the button next to the journal informatiion |
* upstream/main: Enable journal information fetcher directly in popup (JabRef#10598)
Siedlerchr
added
the
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
label
Nov 4, 2023
calixtus
previously approved these changes
Nov 4, 2023
Checkstyle |
Siedlerchr
approved these changes
Nov 4, 2023
Siedlerchr
added a commit
to liyou969/jabref
that referenced
this pull request
Nov 4, 2023
* upstream/main: (44 commits) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (JabRef#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite ...
Siedlerchr
added a commit
to shawn-jj/jabref
that referenced
this pull request
Nov 6, 2023
* upstream/main: fix tests Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625) Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2 Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0 Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0 Change linter (JabRef#10614) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598)
@Siedlerchr sorry I missed this request! |
6 tasks
Siedlerchr
added a commit
to xuanan20020/jabref
that referenced
this pull request
Nov 10, 2023
* upstream/main: (24 commits) Add support for scite.ai (JabRef#10617) Update tests.yml (JabRef#10631) replace "SearchAll" in web search by "Search Selected" (JabRef#10611) Use System preference for light dark theme (JabRef#10593) Fix NPE in lookup identifer Add minimum requirements to CHANGELOG.md (JabRef#10628) Update to JavaFX 21.01 (JabRef#10627) Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549) fix tests Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625) Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2 Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0 Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0 Change linter (JabRef#10614) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again ... # Conflicts: # CHANGELOG.md # src/main/resources/l10n/JabRef_en.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added button next to journal info
Fixes #10124. Started to develop an ISSN fetcher that performs the search based on the identifier given by the user. For the first implementation, I think it's better for us to use the DOAJ Fetcher for searches based on the ISSN number because it's already coupled to our code and makes development easier. In the future, we can couple other Fetchers to perform searches based on the ISSN. There are some fields of the Journals that we can return for the user, like institution, title, publisher, language, keywords, and subject.
Example of return: https://doaj.org/api/search/journals/issn:2579-5341
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)