Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for scite.ai #10617

Merged
merged 26 commits into from
Nov 10, 2023
Merged

Add support for scite.ai #10617

merged 26 commits into from
Nov 10, 2023

Conversation

u7500248
Copy link
Contributor

@u7500248 u7500248 commented Nov 3, 2023

Closes koppor#375

"Add support for scite.ai" - Retrieves scite.ai "Smart Citation" tallies for the selected citation (if a DOI exists)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

image

image

@u7500248 u7500248 marked this pull request as ready for review November 3, 2023 02:43
@Siedlerchr Siedlerchr changed the title Fix for issue 375 Add support for scite.ai Nov 3, 2023
Siedlerchr
Siedlerchr reviewed Nov 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Siedlerchr
Siedlerchr requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall goes into the right direction, just some code style issues

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Nov 3, 2023
@u7500248
Copy link
Contributor Author

u7500248 commented Nov 6, 2023

@Siedlerchr I have made those requested changes, are you able to take another look?

@u7500248
Copy link
Contributor Author

u7500248 commented Nov 8, 2023

@Siedlerchr Thanks for the feedback. I have made the requested changes.

@Siedlerchr
Copy link
Member

LGTM! Just applied some small refactorings and another l10n string.

@Siedlerchr
Copy link
Member

Follow up: Move all the boolean entry editor preferences for each status to an enum Map

@calixtus calixtus added ui entry-editor and removed status: changes required Pull requests that are not yet complete labels Nov 9, 2023
@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed ui entry-editor labels Nov 9, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 9, 2023
Merged via the queue into JabRef:main with commit 8a800e6 Nov 10, 2023
17 checks passed
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 10, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-348
373dec5 
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
@zesaro zesaro mentioned this pull request Jan 15, 2024
Open
@Siedlerchr Siedlerchr mentioned this pull request Sep 14, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
entry-editor status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for scite.ai
3 participants
@u7500248 @Siedlerchr @calixtus