Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10498 Create Fetcher and Transformer for ScholarArchive #10549

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Fix #10498 Create Fetcher and Transformer for ScholarArchive #10549

merged 13 commits into from
Nov 6, 2023

Conversation

liyou969
Copy link
Contributor

@liyou969 liyou969 commented Oct 23, 2023 •
edited by Siedlerchr
Loading

Fix #10498
Create Fetcher and Transformer for ScholarArchive
Is there anything I missed?

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Siedlerchr commented Oct 23, 2023 •
edited
Loading

Please also add a Test and your code style looks odd .You should follow the instructions and import JabRef codestyle https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Oct 23, 2023
@liyou969
Copy link
Contributor Author

Thank you for your comments, I will keep working on

koppor
koppor requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor other comments. Looking forward to the real fetcher tests.

src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ScholarArchiveFetcher.java Outdated Show resolved Hide resolved
...main/java/org/jabref/logic/importer/fetcher/transformers/ScholarArchiveQueryTransformer.java Outdated Show resolved Hide resolved
...main/java/org/jabref/logic/importer/fetcher/transformers/ScholarArchiveQueryTransformer.java Outdated Show resolved Hide resolved
...main/java/org/jabref/logic/importer/fetcher/transformers/ScholarArchiveQueryTransformer.java Outdated Show resolved Hide resolved
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into ScholarArchiveFetcher
c2467cd 
* upstream/main: (44 commits)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (JabRef#10613)
  ShortDoi
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607)
  Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602)
  Update README.md (JabRef#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (JabRef#10587)
  Add button for a user to reset the cite command to the default value. (JabRef#10580)
  openrerwrite
  ...
@Siedlerchr
Finish and fix archive scholar fetcher
d036a40
@Siedlerchr
add url
4692998
@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels Nov 4, 2023
Siedlerchr
Siedlerchr previously approved these changes Nov 6, 2023
View reviewed changes
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 6, 2023
Merged via the queue into JabRef:main with commit a2aa2c6 Nov 6, 2023
17 of 18 checks passed
Siedlerchr added a commit to lisongxuan/jabref that referenced this pull request Nov 9, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Issue#10556-Search-…
c95d0e8 
…Selected

* upstream/main:
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 10, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-348
373dec5 
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scholar.archive.org as fetcher
5 participants
@liyou969 @Siedlerchr @koppor @ThiloteE @u7156540