Use regexp to remove non-ASCII characters from DOI and inform user when data for valid DOI does not exist #8127 #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This was referenced Nov 9, 2021
…from DOI Use regexp to remove non-ASCII, control and non-printable characters from DOI Added language keys to JabRef_en.properties and updated CHANGELOG.md Fixed code style issue Added change to CHANGELOG.md Before merging with origin Use regexp to remove non-ASCII, control and non-printable characters from DOI Squash commits before pulling from origin Use regexp to remove non-ASCII, control and non-printable characters from DOI Squash commits before pulling from origin Added language keys to JabRef_en.properties and updated CHANGELOG.md Use regexp to remove non-ASCII, control and non-printable characters from DOI
…from DOI Squash commits before pulling from origin Squash all commits for this branch
mrcstan
force-pushed
the
fix-for-issue-#8127
branch
from
893ceb5 to
76ecf91
Compare
mrcstan
changed the title
koppor
requested changes
Nov 10, 2021
Siedlerchr
added
the
status: ready-for-review
koppor
approved these changes
Nov 13, 2021
koppor
removed
the
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Nov 19, 2021
* upstream/main: (181 commits) Add of ADRs 22 and 23 (#8256) [Bot] Update CSL styles (#8245) Replace styfle/cancel-workflow-action@0.9.1 by GitHub's "concurrency" feature (#8243) Bump gittools/actions from 0.9.10 to 0.9.11 (#8248) Bump commons-cli from 1.4 to 1.5.0 (#8250) Bump byte-buddy-parent from 1.12.0 to 1.12.1 (#8249) Bump antlr4 from 4.9.2 to 4.9.3 (#8251) Bump archunit-junit5-api from 0.21.0 to 0.22.0 (#8252) Fix search: NOT binds more than AND (#8241) New Crowdin updates (#8240) Make PdfGrobiImporterTest as FetcherTest Oobranch g : add actions (#7792) Fix mixed CRLF / CR (#8238) Fix "Library has changed externally" with CRLF markers (#8239) Fix for issue 8198, 8133 (#8229) Added more unit tests in AuthorTest (#8214) Add confirmation dialog for empty entries in JabRef (#8218) Fix entry editor column visibility (#8232) Use regexp to remove non-ASCII characters from DOI and inform user when data for valid DOI does not exist #8127 (#8228) Fix exception for search flags (#8237) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use single regexp to remove white-space and non-ASCII characters in DOI to fixes #8127. Further inform the user that "No DOI data exists" if DOI is valid and unable to find the article. Works for cases where DOI.findInText does not #8227. For example, the DOI "https : / / doi.org / 10 / gf4gqc" with the quote removed will result in an error not capture by Jabref itself. The reason is that the pattern used by DOI.findInText to extract DOI is not comprehensive. DOI.findInText is only tested in DOITest but not used elsewhere in the source code. However, DOI.parse is used in both DoiFetcher and CompositeIdFetcher, so it is probably better to improve DOI.parse.
With DOI.findInText:
With this PR:
With this PR, user is informed that no data exists if the DOI is valid but no data is found online
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)