Fix for issue 8198, 8133

[sjHong645]

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

I saw the frombooleans method.

'frombooleans' method has 2 parameters.
First parameter needs to be given 'boolean SpecifiedOrder'.
Second parameter needs to be given 'boolean TableOrder'.

Second parameter of previous code was given 'boolean OrigianlOrder'.

So I changed that part.

Fixes #8198

About "JabRefPreferences.java", there is no variable about 'TABLE OrderType'.
So I make it.

Update SaveOrderConfig.java to fix #8133

[sjHong645]

"Update SaveOrderConfig.java" is about #8133

Kopper's comment about WARN in #8133 gave me a clue.
(WARN org.jabref.model.metadata.SaveOrderConfig - Could not parse sort order: specified - trying to parse the sort criteria)

OrderType enum has three things. SPECIFIED, ORIGINAL, TABLE.
Therefore, correct parameter of 'valueof' function is not 'specified', 'original', 'table' but 'SPECIFIED', 'ORIGINAL', 'TABLE'.

So I attach 'toUpperCase' method to parameter of valueof function.

[sjHong645]

Sorry @koppor . Request for you is my mistake. :(

[calixtus]

Now the preferences variable 'EXPORT_IN_ORIGINAL_ORDER` is ignored.
Please do not create a new preferences variable without need, but fix the wrong logic, otherwise we would also have to introduce preferences migrations.
So what the fromBooleans method should really look like is this:

        public static OrderType fromBooleans(boolean saveInSpecifiedOrder, boolean saveInOriginalOrder) {
            SaveOrderConfig.OrderType orderType = OrderType.TABLE;
            if (saveInSpecifiedOrder) {
                orderType = OrderType.SPECIFIED;
            } else if (saveInOriginalOrder) {
                orderType = OrderType.ORIGINAL;
            }

            return orderType;
        }

Also: the default values need to be changed in the defaults-map in JabRefPreferences, not by altering logic.

toUppercase may sound right, although i thought that valueof is case insensitive...

[calixtus]

please adress my remarks.

[sjHong645]

@calixtus

If 'fromBoolean' method is defined as your suggestion,

I think that default value of EXPORT_IN_ORIGINAL_ORDER set 'TRUE' according to your comment.
So I suggest changing as below in JabRefPreferences.java

Because default value of EXPORT_IN_ORIGINAL_ORDER and EXPORT_IN_SPECIFIED_ORDER is all 'FALSE',
Default save order is 'Use current table sort order'

// export order
// defaults.put(EXPORT_IN_ORIGINAL_ORDER, Boolean.FALSE);
defaults.put(EXPORT_IN_ORIGINAL_ORDER, Boolean.TRUE); 
defaults.put(EXPORT_IN_SPECIFIED_ORDER, Boolean.FALSE);

Is it okay?

[calixtus]

Yes, that sound right. Thanks.
Go ahead, push a commit and we'll look into it.

[sjHong645]

@calixtus I did it!

[calixtus]

Looks good to me! Thanks. Looking forward to see more PRs. 😄

[sjHong645]

Thanks for accepting my PR!!