Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry editor column visibility #8232

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Fix entry editor column visibility #8232

merged 4 commits into from
Nov 13, 2021

Conversation

xiaoxianma
Copy link
Contributor

@xiaoxianma xiaoxianma commented Nov 11, 2021

Fixes #7986

Description:
This PR is to fix the entry editor -> Optional Fields tab first column fields invisibility issue when the width is too small.

Solution:
As "Optional Fields tab" is a compressed double columns layout, I'd like to make two columns grow/shrink equally. As such, the first column won't be invisible anymore while the second column is shown.

image

@xiaoxianma xiaoxianma changed the title fix #7986 Fix entry editor column visibility Fix entry editor column visibility Nov 11, 2021
@Siedlerchr
Copy link
Member

Thanks for working on this. Somehow the formatting looks a bit odd. Please check the settings https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#configuration-of-intellij-idea

@xiaoxianma
Copy link
Contributor Author

Thanks for working on this. Somehow the formatting looks a bit odd. Please check the settings https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#configuration-of-intellij-idea

Will do. thx

@xiaoxianma
Copy link
Contributor Author

Thanks for working on this. Somehow the formatting looks a bit odd. Please check the settings https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#configuration-of-intellij-idea

Will do. thx

Code format has been fixed.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 12, 2021
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than the old state 🤩. With a small screen, I still have issues. Can be fixed in a follow-up PR.

grafik

@Siedlerchr Siedlerchr merged commit 5e88576 into JabRef:main Nov 13, 2021
Siedlerchr added a commit that referenced this pull request Nov 19, 2021
* upstream/main: (181 commits)
  Add of ADRs 22 and 23 (#8256)
  [Bot] Update CSL styles (#8245)
  Replace styfle/cancel-workflow-action@0.9.1 by GitHub's "concurrency" feature (#8243)
  Bump gittools/actions from 0.9.10 to 0.9.11 (#8248)
  Bump commons-cli from 1.4 to 1.5.0 (#8250)
  Bump byte-buddy-parent from 1.12.0 to 1.12.1 (#8249)
  Bump antlr4 from 4.9.2 to 4.9.3 (#8251)
  Bump archunit-junit5-api from 0.21.0 to 0.22.0 (#8252)
  Fix search: NOT binds more than AND (#8241)
  New Crowdin updates (#8240)
  Make PdfGrobiImporterTest as FetcherTest
  Oobranch g : add actions (#7792)
  Fix mixed CRLF / CR (#8238)
  Fix "Library has changed externally" with CRLF markers (#8239)
  Fix for issue 8198, 8133 (#8229)
  Added more unit tests in AuthorTest (#8214)
  Add confirmation dialog for empty entries in JabRef (#8218)
  Fix entry editor column visibility (#8232)
  Use regexp to remove non-ASCII characters from DOI and inform user when data for valid DOI does not exist #8127 (#8228)
  Fix exception for search flags (#8237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry editor columns not well adjusted
3 participants