Dummy PR #38
Open
Dummy PR #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: Agoric#9281 ## Description AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform. Doing so for `localChainFacade` is deferred so we can get this into master sooner, to aid @erights 's Agoric#9521 . ### Security Considerations none ### Scaling Considerations Exo for each chain and each account ### Documentation Considerations none ### Testing Considerations Existing coverage ### Upgrade Considerations none, not yet deployed
refs: Agoric#9281 ## Description AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform. Following Agoric#9529 ### Security Considerations none ### Scaling Considerations Exo for each chain and each account ### Documentation Considerations none ### Testing Considerations Existing coverage ### Upgrade Considerations not yet deployed
Vat termination now makes the kernel do a console.log like: `kernel terminating vat v6 (failure=true)` Vat upgrade now announces the start of the upgrade process with: `attempting to upgrade vat v6 from incarnation 0 to source b1-..` in addition to announcing the success or failure of the upgrade `vat v6 upgraded from incarnation 0 to 1 with source b1-..` or `WARNING: vat v6 failed to upgrade from incarnation 0 (startVat)`
refs: Agoric#9449 ## Description - [x] convert icqConnectionKit to return vows - [x] convert Orchestration service (`service.js`) to return vows - [x] convert chainAccountKit to return vows ### Security Considerations ### Scaling Considerations These changes are necessary towards supporting using `orchestration` in `asyncFlow`. ### Documentation Considerations ### Testing Considerations ### Upgrade Considerations
refs: Agoric#9281 ## Description AsyncFlow requires that everything passing the membrane is durable. This makes the ChainHub durable by making it an Exo. ### Security Considerations none ### Scaling Considerations It's a singleton, because there will only be one per vat. ### Documentation Considerations none ### Testing Considerations Existing coverage ### Upgrade Considerations Not yet deployed. Now that it's an Exo, we have to consider its state an upgradability. We expect to make a new one on each vat invocation. The only state it has is cache of AgoricNames and data supplied by the contract.
fix(liquidationVisibility): fix dependency errors
Refs: #24 fix(liquidationVisibility): fix race condition when running tests concurrently fix(liquidationVisibility): fix test-vaultLiquidation.js
author anilhelvaci <anilhelvaci96@gmail.com> 1708371947 +0300 committer anilhelvaci <anilhelvaci96@gmail.com> 1708960452 +0300 fix(liquidationVisibility): lint fix fix(liquidationVisibility): lint fix fix(liquidationVisibility): lint fix fix(liquidationVisibility): fix paths fix(liquidationVisibility): lint and type fixes fix(liquidationVisibility): lint fixes
…date dependencies
…ara instead of state. Refs: #15
…e for readability (WiP) fix(liquidationVisibility): fix unit tests after rebase updates
…ty` in core-eval Refs: #35
…s` and update tests accordingly Refs: #35
…ove `writeLiqVisibility` Refs: #35
…onVisibilityWriters` resulted with below changes; * Use `Promise.all` instead of `allValuesSettled` * Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore * Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans Refs: #35
…lated artifacts. Refs: #35
…sibility method and respective snapshot
anilhelvaci
force-pushed
the
liq-visibility-v2
branch
from
1185474 to
10d4171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dummy PR