Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports release 1.10.5 #54851

Merged
merged 52 commits into from
Aug 13, 2024
Merged

Backports release 1.10.5 #54851

merged 52 commits into from
Aug 13, 2024

Commits on Jun 19, 2024

  1. Allow libquadmath to also fail as it is not available on all systems (#… 

    …54605)

Fix #41613.

Co-authored-by: FX Coudert <fxcoudert@gmail.com>
(cherry picked from commit e5549c2)
    @ViralBShah
    ViralBShah authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7c22da6 View commit details
    Browse the repository at this point in the history

  2. Fix trampoline assembly for build on clang 18 on apple silicon (#54634) 

    This avoids a: `error: non-private labels cannot appear between
.cfi_startproc / .cfi_endproc pairs` error.
That error was introduced in https://reviews.llvm.org/D155245#4657075
see also llvm/llvm-project#72802

(cherry picked from commit a4e793e)
    @gbaraldi
    gbaraldi authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3f35094 View commit details
    Browse the repository at this point in the history

  3. Aggressive constprop in trevc! to stabilize triangular eigvec (#54635) 

    We may use aggressive constprop in `trevc!` to eliminate branches, which
makes the return type of `eigvec(::UpperTriangular)` concretely
inferred.
```julia
julia> @inferred eigvecs(UpperTriangular([1 0; 0 1]))
2×2 Matrix{Float32}:
 1.0  -0.0
 0.0   1.0
```

(cherry picked from commit ea8b4af)
    @jishnub
    jishnub authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e52719b View commit details
    Browse the repository at this point in the history

  4. ensure we set the right value to gc_first_tid (#54645) 

    This may introduce a correctness issue in the work-stealing termination
loop if we're using interactive threads and GC threads simultaneously.

Indeed, if we forget to add `nthreadsi` to `nthreads`, then we're
checking in the mark-loop termination protocol a range `[gc_first_tid,
gc_first_tid + jl_n_markthreads)` of threads which is "shifted to the
left" compared to what it should be.

This implies that we will not be checking whether the GC threads with
higher TID actually have terminated the mark-loop.

(cherry picked from commit c52eee2)
    @d-netto
    d-netto authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    236d2ce View commit details
    Browse the repository at this point in the history

  5. Add boundscheck in bindingkey_eq to avoid OOB access due to data race (… 

    …#54671)

The race here is that svec might be replaced and a new binding
introduced into the keyset while we hold a reference to the old svec,
which led to a OOB access on the svec with the index a binding
introduced at the same time. This now introduces a bounds check which
will force taking the lock if we fail the lookup i.e we had a data race.

Fixes #54285

---------

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 20f03dd)
    @gbaraldi
    gbaraldi authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    936673b View commit details
    Browse the repository at this point in the history

  6. make: Fix sed command for LLVM libraries with no symbol versioning (#… 

    …54672)

If the LLVM library was built without symbol versioning, previously this
would return the `nm` output in its entirety, instead of correctly
reporting "" as the LLVM symbol version.

(cherry picked from commit debaa73)
    @topolarity
    topolarity authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    51e2229 View commit details
    Browse the repository at this point in the history

  7. LazyString in reinterpretarray error messages (#54704) 

    This should remove the dynamic dispatch flagged by JET, e.g. in
```julia
julia> using JET

julia> @report_opt reinterpret(Float64, [1.0im;;])
[ Info: tracking Base
┌ Warning: skipping (::Base.var"#thrownonint#375")(S::Type, T::Type, dim) @ Base reinterpretarray.jl:68 to avoid parsing too much code
└ @ Revise ~/.julia/packages/Revise/bAgL0/src/packagedef.jl:1092
┌ Warning: skipping (::Base.var"#show_bound#661")(io::IO, b) @ Base show.jl:2777 to avoid parsing too much code
└ @ Revise ~/.julia/packages/Revise/bAgL0/src/packagedef.jl:1092
┌ Warning: skipping (::Base.var"#show_bound#661")(io::IO, b) @ Base show.jl:2777 to avoid parsing too much code
└ @ Revise ~/.julia/packages/Revise/bAgL0/src/packagedef.jl:1092
═════ 32 possible errors found ═════
┌ reinterpret(::Type{Float64}, a::Matrix{ComplexF64}) @ Base ./reinterpretarray.jl:88
│┌ (::Base.var"#thrownonint#375")(S::Type{ComplexF64}, T::Type{Float64}, dim::Int64) @ Base ./reinterpretarray.jl:70
││┌ string(::String, ::Type{ComplexF64}, ::String, ::Type{Float64}, ::String, ::Int64, ::String) @ Base ./strings/io.jl:189
│││┌ print_to_string(::String, ::Type{ComplexF64}, ::String, ::Type{Float64}, ::String, ::Int64, ::String) @ Base ./strings/io.jl:148
││││┌ print(io::IOBuffer, x::DataType) @ Base ./strings/io.jl:35
│││││┌ show(io::IOBuffer, x::DataType) @ Base ./show.jl:970
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:975
│││││││┌ show_typealias(io::IOBuffer, x::Type) @ Base ./show.jl:810
││││││││┌ make_typealias(x::Type) @ Base ./show.jl:620
│││││││││┌ modulesof!(s::Set{Module}, x::Type) @ Base ./show.jl:595
││││││││││ runtime dispatch detected: Base.modulesof!(s::Set{Module}, %20::Any)::Any
│││││││││└────────────────────
│││││││││┌ modulesof!(s::Set{Module}, x::Type) @ Base ./show.jl:596
││││││││││ runtime dispatch detected: Base.modulesof!(s::Set{Module}, %34::Any)::Any
│││││││││└────────────────────
│││││││││┌ modulesof!(s::Set{Module}, x::TypeVar) @ Base ./show.jl:589
││││││││││ runtime dispatch detected: Base.modulesof!(s::Set{Module}, %1::Any)::Set{Module}
│││││││││└────────────────────
│││││││┌ show_typealias(io::IOBuffer, x::Type) @ Base ./show.jl:813
││││││││┌ show_typealias(io::IOBuffer, name::GlobalRef, x::Type, env::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:760
│││││││││┌ show_typeparams(io::IOContext{IOBuffer}, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:724
││││││││││┌ show(io::IOContext{IOBuffer}, tv::TypeVar) @ Base ./show.jl:2788
│││││││││││┌ (::Base.var"#show_bound#661")(io::IOContext{IOBuffer}, b::Any) @ Base ./show.jl:2780
││││││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, b::Any)::Any
│││││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOContext{IOBuffer}, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:719
││││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %252::Any)::Any
│││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOContext{IOBuffer}, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:722
││││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %313::Any)::Any
│││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOContext{IOBuffer}, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:727
││││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %191::Any)::Any
│││││││││└────────────────────
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:978
│││││││┌ show_datatype(io::IOBuffer, x::DataType) @ Base ./show.jl:1094
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1097
│││││││││┌ maybe_kws_nt(x::DataType) @ Base ./show.jl:1085
││││││││││ runtime dispatch detected: eltype(%76::DataType)::Any
│││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1186
│││││││││┌ show_typeparams(io::IOBuffer, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:724
││││││││││┌ show(io::IOBuffer, tv::TypeVar) @ Base ./show.jl:2788
│││││││││││┌ (::Base.var"#show_bound#661")(io::IOBuffer, b::Any) @ Base ./show.jl:2780
││││││││││││ runtime dispatch detected: show(io::IOBuffer, b::Any)::Any
│││││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOBuffer, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:719
││││││││││ runtime dispatch detected: show(io::IOBuffer, %250::Any)::Any
│││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOBuffer, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:722
││││││││││ runtime dispatch detected: show(io::IOBuffer, %310::Any)::Any
│││││││││└────────────────────
│││││││││┌ show_typeparams(io::IOBuffer, env::Core.SimpleVector, orig::Core.SimpleVector, wheres::Vector{TypeVar}) @ Base ./show.jl:727
││││││││││ runtime dispatch detected: show(io::IOBuffer, %190::Any)::Any
│││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1157
│││││││││ runtime dispatch detected: show(io::IOBuffer, %224::Any)::Any
││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1162
│││││││││ runtime dispatch detected: show(io::IOBuffer, %54::Any)::Any
││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1148
│││││││││ runtime dispatch detected: show(io::IOBuffer, %57::Any)::Any
││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1150
│││││││││ runtime dispatch detected: show(io::IOBuffer, %54::Any)::Any
││││││││└────────────────────
││││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1172
│││││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOBuffer, %329::Tuple, %328::DataType)::Any
││││││││└────────────────────
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:981
│││││││┌ show_unionaliases(io::IOBuffer, x::Union) @ Base ./show.jl:901
││││││││┌ make_typealiases(x::Union) @ Base ./show.jl:822
│││││││││┌ modulesof!(s::Set{Module}, x::Union) @ Base ./show.jl:595
││││││││││ runtime dispatch detected: Base.modulesof!(s::Set{Module}, %3::Any)::Any
│││││││││└────────────────────
│││││││││┌ modulesof!(s::Set{Module}, x::Union) @ Base ./show.jl:596
││││││││││ runtime dispatch detected: Base.modulesof!(s::Set{Module}, %17::Any)::Any
│││││││││└────────────────────
│││││││┌ show_unionaliases(io::IOBuffer, x::Union) @ Base ./show.jl:914
││││││││ runtime dispatch detected: show(io::IOBuffer, %89::Any)::Any
│││││││└────────────────────
│││││││┌ show_unionaliases(io::IOBuffer, x::Union) @ Base ./show.jl:920
││││││││ runtime dispatch detected: Base.show_typealias(io::IOBuffer, %206::Any, x::Union, %204::Core.SimpleVector, %205::Vector{TypeVar})::Any
│││││││└────────────────────
│││││││┌ show_unionaliases(io::IOBuffer, x::Union) @ Base ./show.jl:928
││││││││ runtime dispatch detected: Base.show_typealias(io::IOBuffer, %269::Any, x::Union, %267::Core.SimpleVector, %268::Vector{TypeVar})::Any
│││││││└────────────────────
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:985
│││││││┌ show_delim_array(io::IOBuffer, itr::Vector{Any}, op::Char, delim::Char, cl::Char, delim_one::Bool) @ Base ./show.jl:1392
││││││││┌ show_delim_array(io::IOBuffer, itr::Vector{Any}, op::Char, delim::Char, cl::Char, delim_one::Bool, i1::Int64, l::Int64) @ Base ./show.jl:1403
│││││││││ runtime dispatch detected: show(%3::IOContext{IOBuffer}, %52::Any)::Any
││││││││└────────────────────
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:1012
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1185
││││││││┌ show_type_name(io::IOContext{IOBuffer}, tn::Core.TypeName) @ Base ./show.jl:1059
│││││││││ runtime dispatch detected: Base.isvisible(%29::Symbol, %86::Module, %80::Any)::Bool
││││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1157
││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %227::Any)::Any
│││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1162
││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %55::Any)::Any
│││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1148
││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %58::Any)::Any
│││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1150
││││││││ runtime dispatch detected: show(io::IOContext{IOBuffer}, %55::Any)::Any
│││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1172
││││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOContext{IOBuffer}, %338::Tuple, %337::DataType)::Any
│││││││└────────────────────
│││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1180
││││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOContext{IOBuffer}, %387::Tuple, %391::DataType)::Any
│││││││└────────────────────
││││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:1014
│││││││ runtime dispatch detected: show(%98::IOContext{IOBuffer}, %99::Any)::Any
││││││└────────────────────
│││││┌ show(io::IOBuffer, x::DataType) @ Base ./show.jl:970
││││││ runtime dispatch detected: Base._show_type(io::IOBuffer, %1::Any)::Nothing
│││││└────────────────────
```

(cherry picked from commit b54c688)
    @jishnub
    jishnub authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9fac394 View commit details
    Browse the repository at this point in the history

  8. make: use readelf for LLVM symbol version detection (#54713) 

    Apparently on some distributions `nm --with-symbol-versions` does not
report symbol versions, despite the flag.

`readelf` should be a more reliable alternative which is also part of
binutils.

See spack/spack#44534 (comment)
for more information

(cherry picked from commit d0f165f)
    @topolarity
    topolarity authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    005fd2f View commit details
    Browse the repository at this point in the history

  9. [LinearAlgebra] Improve resilience to unknown libblastrampoline flags (… 

    …#54781)

When testing a new version of `libblastrampoline` that may have flags
and values that we don't know about, raise a nice warning rather than a
hard error.

(cherry picked from commit 5044506)
    @staticfloat
    staticfloat authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fb977a2 View commit details
    Browse the repository at this point in the history

  10. add sticky task warning to @task and schedule (#54815) 

    The fact that `@async` causes the task that it was scheduled from to
also become sticky is well documented in the warning in [`@async`
docs](https://docs.julialang.org/en/v1/base/parallel/#Base.@async), but
it's not clear that creating a task and scheduling it also has the same
effect, by default.

(cherry picked from commit a9b4869)
    @IanButterworth
    IanButterworth authored and KristofferC committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    82aa263 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Do not add type tag size to the alloc_typed lowering for GC allocat… 

    …ions (#54837)

Enzyme.jl hit an issue where, in a dynamically typed allocation of size
`GC_MAX_SZCLASS`, because we mistakenly added they type tag size to the
allocation, the runtime disagreed if this was a pool allocation or a big
allocation. Causing a crash in the GC

(cherry picked from commit ded0b28)
    @gbaraldi @vchuravy
    gbaraldi authored and vchuravy committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    48e140b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. 🤖 [backports-release-1.10] Bump the Pkg stdlib from f487626b0 to 6d73… 

    …ac1fc (#55114)
    @DilumAluthgeBot
    DilumAluthgeBot authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    9af34c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. LinearAlgebra: use ≈ instead of == for tr tests in symmetric.jl (… 

    …#55143)

After investigating #54090, I found that the issue was
not caused by the effects of `checksquare`, but by the use of the
`@simd` macro within `tr(::Matrix)`:

https://github.com/JuliaLang/julia/blob/0945b9d7740855c82a09fed42fbf6bc561e02c77/stdlib/LinearAlgebra/src/dense.jl#L373-L380

While simply removing the `@simd` macro was considered, the strict
left-to-right summation without `@simd` otherwise is not necessarily
more accurate, so I concluded that the problem lies in the test code,
which tests the (strict) equality of two different `tr` execution
results. I have modified the test code to use `≈` instead of `==`.

- fixes #54090
    @aviatesk
    aviatesk committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    396ef27 View commit details
    Browse the repository at this point in the history

  2. LazyString in LinearAlgebra.checksquare error message (#53961) 

    This reduces dynamic dispatch and makes JET happier.
Testing on v1.11:
```julia
julia> import LinearAlgebra: checksquare

julia> using JET

julia> @report_opt checksquare(rand(2,2), rand(2,2))
═════ 4 possible errors found ═════
┌ checksquare(::Matrix{Float64}, ::Matrix{Float64}) @ LinearAlgebra /cache/build/builder-amdci4-1/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/LinearAlgebra/src/LinearAlgebra.jl:307
│┌ string(::String, ::Tuple{Int64, Int64}) @ Base ./strings/io.jl:189
││┌ print_to_string(::String, ::Tuple{Int64, Int64}) @ Base ./strings/io.jl:150
│││┌ _unsafe_take!(io::IOBuffer) @ Base ./iobuffer.jl:494
││││┌ wrap(::Type{Array}, m::MemoryRef{UInt8}, l::Int64) @ Base ./array.jl:3101
│││││ failed to optimize due to recursion: wrap(::Type{Array}, ::MemoryRef{UInt8}, ::Int64)
││││└────────────────────
│││┌ print_to_string(::String, ::Vararg{Any}) @ Base ./strings/io.jl:143
││││ runtime dispatch detected: Base._str_sizehint(%17::Any)::Int64
│││└────────────────────
│││┌ print_to_string(::String, ::Vararg{Any}) @ Base ./strings/io.jl:148
││││ runtime dispatch detected: print(%59::IOBuffer, %97::Any)::Any
│││└────────────────────
│││┌ string(::String, ::Int64, ::String, ::Tuple{Int64}, ::String, ::Int64, ::String, ::Int64, ::String) @ Base ./strings/io.jl:189
││││ failed to optimize due to recursion: string(::String, ::Int64, ::String, ::Tuple{Int64}, ::String, ::Int64, ::String, ::Int64, ::String)
│││└────────────────────

julia> function checksquare(A...) # This PR
                  sizes = Int[]
                  for a in A
                      size(a,1)==size(a,2) || throw(DimensionMismatch(lazy"matrix is not square: dimensions are $(size(a))"))
                      push!(sizes, size(a,1))
                  end
                  return sizes
              end
checksquare (generic function with 2 methods)

julia> @report_opt checksquare(rand(2,2), rand(2,2))
No errors detected

```
    @jishnub @aviatesk
    jishnub authored and aviatesk committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ddf7090 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Remove boxing in pinv (#51351) 

    As discussed in
https://discourse.julialang.org/t/pinv-not-type-stable/103885/14, the
`tol` variable is captured which leads to it being boxed, as suggested
can be fixed by having two separate variables.

(cherry picked from commit 8e21b21)
    @Zentrik @KristofferC
    Zentrik authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4499295 View commit details
    Browse the repository at this point in the history

  2. Profile: Improve module docstring (#52678) 

    ![Screenshot 2023-12-30 at 7 24
10 PM](https://github.com/JuliaLang/julia/assets/1694067/a7c78943-5e4a-475c-864c-3b0005305471)

(cherry picked from commit 0f62824)
    @IanButterworth @KristofferC
    IanButterworth authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6c58b41 View commit details
    Browse the repository at this point in the history

  3. Fix generic triangular solves with empty matrices (#54201) 

    (cherry picked from commit 8945914)
    @dkarrasch @KristofferC
    dkarrasch authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bfa01f9 View commit details
    Browse the repository at this point in the history

  4. Update the aarch64 devdocs to reflect the current state of its support ( 

    #55141)

The devdocs here reflect a time when aarch64 was much less well
supported, it also reference Cudadrv which has been archived for years

(cherry picked from commit 2efcfd9)
    @gbaraldi @KristofferC
    gbaraldi authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4b0f303 View commit details
    Browse the repository at this point in the history

  5. Compat for Base.@nospecializeinfer (#55178) 

    This macro was added in v1.10 but was missing a compat notice.

(cherry picked from commit 3290904)
    @mikmoore @KristofferC
    mikmoore authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9ca08e9 View commit details
    Browse the repository at this point in the history

  6. compat notice for a[begin] indexing (#55197) 

    `a[begin]` indexing was added by #35779 in Julia 1.6, so this feature
needs a compat notice in the docstring.

(cherry picked from commit 43df7fb)
    @stevengj @KristofferC
    stevengj authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    21d33b4 View commit details
    Browse the repository at this point in the history

  7. correction to compat notice for a[begin] (#55209) 

    Correction to #55197: `a[begin]` indexing was added in Julia 1.4
(#33946), not in Julia 1.6 (which just changed the implementation in
#35779). My bad.

(cherry picked from commit 06467eb)
    @stevengj @KristofferC
    stevengj authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6225d9a View commit details
    Browse the repository at this point in the history

  8. document mutable struct const fields (#55203) 

    Introduced in #43305

(cherry picked from commit 6b08e80)
    @IanButterworth @KristofferC
    IanButterworth authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    43cdc58 View commit details
    Browse the repository at this point in the history

  9. more precise aliasing checks for SubArray (#54624) 

    This avoids returning false positives where only the indices are shared.
As the indices are not mutated by array assignments (and are explicitly
warned against mutation in general), we can ignore the case where _only_
the indices are aliasing.

Fix #54621

(cherry picked from commit 97bf148)
    @mbauman @KristofferC
    mbauman authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4b063cf View commit details
    Browse the repository at this point in the history

  10. Fix assertion/crash when optimizing function with dead basic block (#… 

    …54690)

AllocOpt probably needs to handle that in other places more smartly but
this seems to at least stop it crashing. Fixes issue found in
#54604 (comment) by
@topolarity.

(cherry picked from commit 5cb1107)
    @gbaraldi @KristofferC
    gbaraldi authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6ee9546 View commit details
    Browse the repository at this point in the history

  11. Use triple quotes in TOML.print when string contains newline (#55084) 

    closes #55083

Shouldu this also check for `\r`?

---------

Co-authored-by: Alex Arslan <ararslan@comcast.net>
(cherry picked from commit e732706)
    @palday @KristofferC
    palday authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8b72c09 View commit details
    Browse the repository at this point in the history

  12. LinearAlgebra: LazyString in error messages for Diagonal/Bidiagonal (#… 

    …55070)

(cherry picked from commit ec013f1)
    @jishnub @KristofferC
    jishnub authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9591961 View commit details
    Browse the repository at this point in the history

  13. add missing compat entry to edit (#54769) 

    (cherry picked from commit 3f8e1bd)
    @palday @KristofferC
    palday authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c7bf7b8 View commit details
    Browse the repository at this point in the history

  14. Bump libblastrampoline to v5.10.1 (#54791) 

    This release fixes issues with complex valued returns from functions
such as `cdotc` on Windows x64. See this discussion [0] for initial
diagnosis, and this PR [1] for the relevant fixes.

[0] JuliaLinearAlgebra/BLISBLAS.jl#15
[1] JuliaLinearAlgebra/libblastrampoline#129

(cherry picked from commit 3054c00)
    @staticfloat @KristofferC
    staticfloat authored and KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    dbb0640 View commit details
    Browse the repository at this point in the history

  15. bump Pkg to latest v1.10

    @KristofferC
    KristofferC committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c632ee6 View commit details
    Browse the repository at this point in the history

  16. Disable typed pointer tests for alloc-opt-pass since the base file is… 

    … now using opaque pointers
    @gbaraldi
    gbaraldi committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    884c71e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Remove reference to memory attribute in llvm pass

    @gbaraldi
    gbaraldi committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b8c84fd View commit details
    Browse the repository at this point in the history

  2. relax equality in trace test

    @KristofferC
    KristofferC committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6cd6f8d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Fix calling LLVM_SIZE on windows (#53902) 

    Per
JuliaCI/julia-buildkite#224 (comment),
the path needs to be updated so that `llvm-size` can find `libLLVM.dll`.

(cherry picked from commit 657ce04)
    @Zentrik @KristofferC
    Zentrik authored and KristofferC committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    71b0b31 View commit details
    Browse the repository at this point in the history

  2. fixup some casts in uv code, extraced from commit e5496e0

    @KristofferC
    KristofferC committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    23fb255 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Do not hide libssp.dll.a (Windows import library) in private library … 

    …dir (#52820)

Fix #51740

Since we are providing libssp.dll on Windows and we want to dynamically
link to it, exposing libssp.dll.a is necessary. The inconsistency is
that libjulia-codegen.so looks in build_libdir and build_private_libdir
while standard library precompilation looks in build_shlibdir and
build_private_dir.

(cherry picked from commit c3836e1)
    @mkitti @KristofferC
    mkitti authored and KristofferC committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6dc961c View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Remove the WarnMissedTransformations pass from the 1.10 pipeline (#55377 

    )

Backport of #54871 onto 1.10

We don't have the luxury of modifying the C-API. This pass surfaces LLVM
missed transformation warnings,
which is surprising to users. It can be very helpful, but it can also
add unactionable noise to the output
of Julia programs.

This PR simply removes it from the pipeline.
    @vchuravy
    vchuravy authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b5d12a5 View commit details
    Browse the repository at this point in the history

  2. Add openlibm to sysimg link line on windows (#53672) 

    LLVM generates calls to math intrinsics like `trunc` and `rint` (at
least in my local i686 mingw) build, so linking to openlibm is required.
We already have this on the sysimg link line in `Base.link_image`, so
this aligns those options.

---------

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 320366b)
    @Keno @KristofferC
    Keno authored and KristofferC committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1de44ab View commit details
    Browse the repository at this point in the history

  3. 🤖 [backports-release-1.10] Bump the Pkg stdlib from bf83c387b to ff18… 

    …647d8 (#55385)
    @DilumAluthgeBot
    DilumAluthgeBot authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b1fee19 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. [build] Some improvements to the LLVM build system (#55354) 

    After #55180 we implicitly require an LLVM built with Zlib support, but
compiling Julia with `make USE_BINARYBUILDER_LLVM=0` builds an LLVM
without Zlib support, despite the fact we attempt to request it at

https://github.com/JuliaLang/julia/blob/996351f5f6651d1508aef3c35c7d37eb22a0fb1e/deps/llvm.mk#L97
This was first identified in #55337.

`ZLIB_LIBRARY` must be the path to the zlib library, but we currently
set it to the libdir where the library is installed (introduced in

https://github.com/JuliaLang/julia/blob/996351f5f6651d1508aef3c35c7d37eb22a0fb1e/deps/llvm.mk#L97
which is wrong. However, CMake is actually able to find Zlib correctly,
but then the check at
https://github.com/llvm/llvm-project/blob/46425b8d0fac3c529aa4a716d19abd7032e452f3/llvm/cmake/config-ix.cmake#L139-L141
uses the value of `ZLIB_LIBRARY` to list the Zlib to link for the test,
but being `ZLIB_LIBRARY` a directory, CMake doesn't see any valid Zlib
and thus tries to run the test without linking any Zlib, and the test
silently fails (they're silent only when `LLVM_ENABLE_ZLIB=ON`),
resulting in no usable Zlib available, even if found.

`ZLIB_ROOT` is the only [hint recommended by the CMake module
`FindZLIB`](https://cmake.org/cmake/help/latest/module/FindZLIB.html#hints).
This PR replaces a broken `ZLIB_LIBRARY` with an appropriate
`ZLIB_ROOT`. Also, we set `LLVM_ENABLE_ZLIB=FORCE_ON` which is the only
way to make CMake fail loudly if no usable Zlib is available, and avoid
going on with a non-usable build.

I confirm this fixes #55337 for me, it should likely address
JuliaCI/julia-buildkite#373 as well.

Also, options `COMPILER_RT_ENABLE_IOS`, `COMPILER_RT_ENABLE_WATCHOS`,
`COMPILER_RT_ENABLE_TVOS`, and `HAVE_HISTEDIT_H` don't exist anymore,
and they are removed.
    @giordano
    giordano committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0be37db View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. AllocOpt: Fix stack lowering where alloca continas boxed and unboxed … 

    …data (#55306) (#55397)

…data (#55306)

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
    @wsmoses @vchuravy
    @giordano @gbaraldi
    4 people authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1b641c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. [docs] change docstring to match code (#55013) 

    The docstring of `LinearAlgebra.reflectorApply!` is incorrect. It says
the function is applying `(I - τ*[1; x] * [1; x]')*A`, but in reality it
is applying `(I - conj(τ)*[1; x[2:end]]*[1; x[2:end]]')*A`. You can
check that by looking at the code, or running for example
```julia
using LinearAlgebra
T=ComplexF64;d=5;
τ=randn(T);x=randn(T,d);A=randn(T,d,d);
(I - conj(τ)*[1; x[2:end]]*[1; x[2:end]]')*A
LinearAlgebra.reflectorApply!(x,τ,A)
```

(cherry picked from commit 1ece299)
    @araujoms
    araujoms authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f91f502 View commit details
    Browse the repository at this point in the history

  2. Fix a bug in stack's DimensionMismatch error message (#54033) 

    `stack` does not require that the inner iterator defines `axes`, but the
code to assemble an error message assumed this.

Found here:
https://discourse.julialang.org/t/reduce-hcat-is-type-unstable/112800/3

(cherry picked from commit ae483c3)
    @mcabbott
    mcabbott authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    980b83d View commit details
    Browse the repository at this point in the history

  3. Add lbt_forwarded_funcs() to debug LBT forwarding issues (#55302) 

    It can be very helpful, when struggling with LBT forwarding, to see what
functions were actually forwarded to a new library. This utility
function makes it easy to query which functions are forwarded to that
library.

(cherry picked from commit e0f2e29)
    @staticfloat
    staticfloat authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f705611 View commit details
    Browse the repository at this point in the history

  4. Restrict argument to isleapyear(::Integer) (#55317) 

    In 1.10 we have

```jl
julia> isleapyear(Year(1992))
false
```

which is semantically incorrect because `Year(1992)` is a duration (1992
years), not an instant. This PR restricts the currently unrestricted
argument to integers.

(cherry picked from commit fdecc59)
    @jariji
    jariji authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2eef480 View commit details
    Browse the repository at this point in the history

  5. Profile: Fix stdlib paths (#55327) 

    (cherry picked from commit b759fe2)
    @IanButterworth
    IanButterworth authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    82dc2d6 View commit details
    Browse the repository at this point in the history

  6. [libblastrampoline] Bump to v5.11.0 (#55330) 

    This includes support to properly forward MKL v2024's ILP64 CBLAS
symbols, which fixes this [Enzyme
issue](EnzymeAD/Enzyme.jl#1683)

(cherry picked from commit 602b582)
    @staticfloat
    staticfloat authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a28e527 View commit details
    Browse the repository at this point in the history

  7. Fix tr for block SymTridiagonal (#55371) 

    This ensures that `tr` for a block `SymTridiagonal` symmetrizes the
diagonal elements.

(cherry picked from commit a163483)
    @jishnub
    jishnub authored and KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    67ac373 View commit details
    Browse the repository at this point in the history

  8. bump Pkg to latest 1.10

    KristofferC committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fd6d9e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. stale_cachefile: handle if the expected cache file is missing (#55419) 

    Part of fixing JuliaLang/Pkg.jl#3984
    @IanButterworth
    IanButterworth committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3a4ccaa View commit details
    Browse the repository at this point in the history

  2. 🤖 [backports-release-1.10] Bump the Pkg stdlib from 9cb6d35f8 to 4552… 

    …1a6e8 (#55437)

Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: release-1.10
Julia branch: backports-release-1.10
Old commit: 9cb6d35f8
New commit: 45521a6e8
Julia version: 1.10.4
Pkg version: 1.10.0(Does not match)
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@9cb6d35...45521a6

```
$ git log --oneline 9cb6d35f8..45521a6e8
45521a6e8 backport extension dependency modeling from Base 1.11 to Pkg 1.10 (#3986)
1810b1123 don't swallow internal errors (#3987)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
    @DilumAluthgeBot @DilumAluthge
    DilumAluthgeBot and DilumAluthge authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b4b1646 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. 🤖 [backports-release-1.10] Bump the Pkg stdlib from 45521a6e8 to a4f2… 

    …6cff6 (#55463)

Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: release-1.10
Julia branch: backports-release-1.10
Old commit: 45521a6e8
New commit: a4f26cff6
Julia version: 1.10.4
Pkg version: 1.10.0(Does not match)
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@45521a6...a4f26cf

```
$ git log --oneline 45521a6e8..a4f26cff6
a4f26cff6 [release-1.10] Pkg.precompile: Handle when the terminal is very short (#3988)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
    @DilumAluthgeBot @DilumAluthge
    DilumAluthgeBot and DilumAluthge authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    746ea6a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. bump Pkg to latest 1.10

    KristofferC committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5b677f9 View commit details
    Browse the repository at this point in the history