-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set .jl
sources as read-only during installation
#55524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets all `.jl` files in `$(prefix)/base` and `$(prefix)/test` to have `0444` permissions, to better match how `Pkg` installs packages (and sets them to be read-only). Fixes JuliaLang/juliaup#865
giordano
reviewed
Aug 19, 2024
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Does this only affect |
|
giordano
added
backport 1.10
Change should be backported to the 1.10 release
backport 1.11
Change should be backported to release-1.11
labels
Aug 19, 2024
staticfloat
added a commit
that referenced
this pull request
Aug 20, 2024
We previously did this for `base` and `test` in #55524, may as well do it for `stdlib` as well.
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2024
This sets all `.jl` files in `$(prefix)/base` and `$(prefix)/test` to have `0444` permissions, to better match how `Pkg` installs packages (and sets them to be read-only). Fixes JuliaLang/juliaup#865 --------- Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> (cherry picked from commit 62e7705)
33 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
This sets all `.jl` files in `$(prefix)/base` and `$(prefix)/test` to have `0444` permissions, to better match how `Pkg` installs packages (and sets them to be read-only). Fixes JuliaLang/juliaup#865 --------- Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
This sets all `.jl` files in `$(prefix)/base` and `$(prefix)/test` to have `0444` permissions, to better match how `Pkg` installs packages (and sets them to be read-only). Fixes JuliaLang/juliaup#865 --------- Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> (cherry picked from commit 62e7705)
KristofferC
added a commit
that referenced
this pull request
Sep 17, 2024
Backported PRs: - [x] #55480 <!-- Fix push! for OffsetVectors, add tests for push! and append! on AbstractVector --> - [x] #55443 <!-- Add test for upper/lower/titlecase and fix call --> - [x] #55524 <!-- Set `.jl` sources as read-only during installation --> - [x] #55500 <!-- make jl_thread_suspend_and_get_state safe --> - [x] #55506 <!-- Fix indexing in _mapreducedim for OffsetArrays --> - [x] #55564 <!-- Empty out loaded_precompiles dict instead of asserting it's empty. --> - [x] #55567 <!-- Initialize threadpools correctly during sysimg build --> - [x] #55596 <!-- Fast bounds-check for CartesianIndex ranges --> - [x] #55605 <!-- Reroute Symmetric/Hermitian + Diagonal through triangular --> - [x] #55640 <!-- win: move stack_overflow_warning to the backtrace fiber --> - [x] #55715 <!-- Add precompile signatures to Markdown to reduce latency. --> - [x] #55593 <!-- Fix invalidations for FileIO --> - [x] #55555 <!-- Revert "Don't expose guard pages to malloc_stack API consumers" --> - [x] #55720 <!-- Fix `pkgdir` for extensions --> - [x] #55729 <!-- Avoid confounding compilation side effects of `@time_imports` --> - [x] #55718 <!-- Fix `@time_imports` extension recognition --> - [x] #55522 <!-- Fix tr for Symmetric/Hermitian block matrices --> Contains multiple commits, manual intervention needed: - [ ] #55509 <!-- Fix cong implementation to be properly random and not just cycling. --> Non-merged PRs with backport label: - [ ] #55641 <!-- fall back to slower stat filesize if optimized filesize fails --> - [ ] #55534 <!-- Set stdlib sources as read-only during installation --> - [ ] #55499 <!-- propagate the terminal's `displaysize` to the `IOContext` used by the REPL --> - [ ] #55458 <!-- Allow for generically extracting unannotated string --> - [ ] #55457 <!-- Make AnnotateChar equality consider annotations --> - [ ] #55453 <!-- Privatise the annotations API, for StyledStrings --> - [ ] #55355 <!-- relocation: account for trailing path separator in depot paths --> - [ ] #55220 <!-- `isfile_casesensitive` fixes on Windows --> - [ ] #55169 <!-- `propertynames` for SVD respects private argument --> - [ ] #54457 <!-- Make `String(::Memory)` copy --> - [ ] #53957 <!-- tweak how filtering is done for what packages should be precompiled --> - [ ] #51479 <!-- prevent code loading from lookin in the versioned environment when building Julia --> - [ ] #50813 <!-- More doctests for Sockets and capitalization fix --> - [ ] #50157 <!-- improve docs for `@inbounds` and `Base.@propagate_inbounds` --> - [ ] #41244 <!-- Fix shell `cd` error when working dir has been deleted -->
KristofferC
removed
the
backport 1.11
Change should be backported to release-1.11
label
Sep 17, 2024
KristofferC
added a commit
that referenced
this pull request
Oct 22, 2024
Backported PRs: - [x] #51755 <!-- ASAN fixes. --> - [x] #55329 <!-- mapreduce: don't inbounds unknown functions --> - [x] #55365 <!-- ml-matches: ensure all methods are included --> - [x] #55483 <!-- fix hierarchy level of "API reference" in `Dates` documentation --> - [x] #55268 <!-- simplify complex atanh and remove singularity perturbation --> - [x] #55504 <!-- Update symmetric docstring to reflect the type of uplo --> - [x] #55524 <!-- Set `.jl` sources as read-only during installation --> - [x] #41244 <!-- Fix shell `cd` error when working dir has been deleted --> - [x] #55829 <!-- [Dates] Make test more robust against non-UTC timezones --> - [x] #55641 <!-- fall back to slower stat filesize if optimized filesize fails --> - [x] #55849 <!-- Mmap: fix grow! for non file IOs --> - [x] #55945 <!-- Fix logic in `?` docstring example --> - [x] #55743 <!-- doc: heap snapshot viewing --> - [x] #56023 <!-- Sockets: Warn when local network access not granted. --> - [x] #54276 <!-- Fix solve for complex `Hermitian` with non-vanishing imaginary part on diagonal --> - [x] #54669 <!-- Improve error message in inplace transpose --> - [x] #55295 <!-- LAPACK: Aggressive constprop to concretely infer syev!/syevd! --> - [x] #55303 <!-- avoid overflowing show for OffsetArrays around typemax --> - [x] #55342 <!-- Ensure bidiagonal setindex! does not read indices in error message --> - [x] #55507 <!-- Fix fast getptls ccall lowering. --> - [x] #55522 <!-- Fix tr for Symmetric/Hermitian block matrices --> - [x] #55854 <!-- 🤖 [master] Bump the Downloads stdlib from 1061ecc to 89d3c7d --> - [x] #55863 <!-- Update TaskLocalRNG docstring according to #49110 --> - [x] #55567 <!-- Initialize threadpools correctly during sysimg build --> - [x] #55506 <!-- Fix indexing in _mapreducedim for OffsetArrays --> - [x] #54737 <!-- LazyString in interpolated error messages involving types -->
KristofferC
removed
the
backport 1.10
Change should be backported to the 1.10 release
label
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets all
.jl
files in$(prefix)/base
and$(prefix)/test
to have0444
permissions, to better match howPkg
installs packages (and sets them to be read-only).Fixes JuliaLang/juliaup#865