Backports for 1.11.0-rc4/1.11.0 #55586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets all `.jl` files in `$(prefix)/base` and `$(prefix)/test` to have `0444` permissions, to better match how `Pkg` installs packages (and sets them to be read-only). Fixes JuliaLang/juliaup#865 --------- Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> (cherry picked from commit 62e7705)
Fixes async safety, thread safety, FreeBSD safety. (cherry picked from commit d4bd540)
The destination array was being indexed incorrectly if it had offset
indices. This led to the following on nightly:
```julia
julia> using OffsetArrays
julia> r = 5:100;
julia> a = OffsetVector(r, 2);
julia> sum(a, dims=1)
1-element OffsetArray(::Vector{Int64}, 3:3) with eltype Int64 with indices 3:3:
0
julia> sum(a)
5040
```
The indexing was marked `@inbounds`, so this was not throwing an error.
This PR also follows #55329 and only marks the indexing operations as
`@inbounds`, omitting the function calls.
---------
Co-authored-by: Matt Bauman <mbauman@juliahub.com>
(cherry picked from commit 3d20a92)
…1061ecc (#55615) Stdlib: Downloads URL: https://github.com/JuliaLang/Downloads.jl.git Stdlib branch: master Julia branch: backports-release-1.11 Old commit: a9d274f New commit: 1061ecc Julia version: 1.11.0-rc2 Downloads version: 1.6.0(It's okay that it doesn't match) Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Downloads.jl@a9d274f...1061ecc ``` $ git log --oneline a9d274f..1061ecc 1061ecc Fix setting atexit. Fixes trailing download tasks during precompilation (#257) b871386 Add debug information to `setopt` commands (#248) 51e5321 fix: use invokelatest for easy_hook, avoid race (#241) 05f9ec2 make precompile workload relocatable (#236) 2dd891a Hardcode doc edit backlink (#232) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
…actVector (#55480) Per #55470 (comment), the `push!(::AbstractArray, ...)` array implementation assumed one-based indexing and did not account for an `OffsetVector` scenario. Here we add tests for `push!(::AbstractArray, ...)` and `append(::AbstractArray, ...)` including using `@invoke` to test the effect on `OffsetVector`. cc: @fredrikekre (cherry picked from commit 5230d27)
I made a mistake with which threadpool was which. (cherry picked from commit d5bbcc5)
`StepRangeLen{<:CartesianIndex}` indices have been supported since
v1.11, but bounds-checking for such indices currently falls back to
iterating over the entire range. This PR adds a quick `checkindex` for
such ranges.
The performance improvement as a consequence:
```julia
julia> D = Diagonal(1:10_000);
julia> @Btime checkbounds($D, diagind($D, IndexCartesian()));
6.697 μs (0 allocations: 0 bytes) # nightly, O(n)
4.044 ns (0 allocations: 0 bytes) # This PR, O(1)
```
(cherry picked from commit 6440292)
There is not enough stack space remaining after a stack overflow on Windows to allocate the 4k page used by `write` to call the WriteFile syscall. This causes it to hard-crash. But we can simply run this on the altstack implementation, where there is plenty of space. (cherry picked from commit eebc1e4)
(cherry picked from commit 39eaa3c)
This reverts commit 5dfd57d.
This should fix the `Diagonal`-related issue from #55590, although the `SymTridiagonal` one still remains. ```julia julia> using LinearAlgebra julia> a = Matrix{BigFloat}(undef, 2,2) 2×2 Matrix{BigFloat}: #undef #undef #undef #undef julia> a[1] = 1; a[3] = 1; a[4] = 1 1 julia> a = Hermitian(a) 2×2 Hermitian{BigFloat, Matrix{BigFloat}}: 1.0 1.0 1.0 1.0 julia> b = Symmetric(a) 2×2 Symmetric{BigFloat, Matrix{BigFloat}}: 1.0 1.0 1.0 1.0 julia> c = Diagonal([1,1]) 2×2 Diagonal{Int64, Vector{Int64}}: 1 ⋅ ⋅ 1 julia> a+c 2×2 Hermitian{BigFloat, Matrix{BigFloat}}: 2.0 1.0 1.0 2.0 julia> b+c 2×2 Symmetric{BigFloat, Matrix{BigFloat}}: 2.0 1.0 1.0 2.0 ``` (cherry picked from commit 39f2ad1)
Fixes #55706 that is seemingly a 4472x regression, not just 16x (was my first guess, based on CondaPkg, also fixes or greatly mitigates JuliaPy/CondaPkg.jl#145), and large part of 3x regression for PythonCall. --------- Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 1463c99)
Fixes JuliaIO/FileIO.jl#396 (cherry picked from commit 68feddc)
(cherry picked from commit d280792)
No idea why Pkg would start failing... Actually, it must be 598a4de... |
This backports the following commits:
commit 9690961c426ce2640d7db6c89952e69f87873a93
Author: Jishnu Bhattacharya <jishnub.github@gmail.com>
Date: Mon Apr 29 21:43:31 2024 +0530
Add upper/lowertriangular functions and use in applytri (#53573)
We may use the fact that a `Diagonal` is already triangular to avoid
adding a wrapper.
Fixes the specific example in
#53564, although not the
broader issue. This is because it changes the operation from a
`UpperTriangular + UpperTriangular` to a `UpperTriangular + Diagonal`,
which uses broadcasting. The latter operation may also allow one to
define more efficient methods.
commit 77821cdddb968eeabf31ccb6b214ccf59a604c68
Author: Jishnu Bhattacharya <jishnub.github@gmail.com>
Date: Wed Aug 28 00:53:31 2024 +0530
Remove Diagonal-triangular specialization
commit 621fb2e739a04207df63857700aca3562b41b5eb
Author: Jishnu Bhattacharya <jishnub.github@gmail.com>
Date: Wed Aug 28 00:50:49 2024 +0530
Restrict broadcasting to strided-diag Diagonal
commit 58eb2045ddb5dbbfdb759c06239ca54751e73d71
Author: Jishnu Bhattacharya <jishnub.github@gmail.com>
Date: Wed Aug 28 00:44:47 2024 +0530
Add tests for partly filled parent
commit 5aa6080a580bfbc9453e94a06f3e379e4517b316
Author: Jishnu Bhattacharya <jishnub.github@gmail.com>
Date: Tue Aug 27 20:42:07 2024 +0530
Reroute Symmetric/Hermitian + Diagonal through triangular
jishnub
force-pushed
the
backports-release-1.11
branch
from
d40fa57
to
4ab4722
Compare
|
I had messed up the cherry-pick, and amended the commit to keep the history clean. Hope this doesn't lead to inconvenience. |
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. |
aviatesk
force-pushed
the
backports-release-1.11
branch
from
41b225a
to
1c516dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
.jlsources as read-only during installation #55524pkgdirfor extensions #55720@time_imports#55729@time_importsextension recognition #55718Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
displaysizeto theIOContextused by the REPL #55499isfile_casesensitivefixes on Windows #55220propertynamesfor SVD respects private argument #55169String(::Memory)copy #54457@inboundsandBase.@propagate_inbounds#50157cderror when working dir has been deleted #41244