New version: AWSCore v0.6.8 #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Jan 29, 2020
JuliaRegistrator
commented
- Registering package: AWSCore
- Repository: https://github.com/JuliaCloud/AWSCore.jl
- Created by: @mattBrzezinski
- Version: v0.6.8
- Commit: 0da160afae83101ee58a02e4e7cad68a9ad1631d
- Reviewed by: @mattBrzezinski
- Reference: JuliaCloud/AWSCore.jl@0da160a#commitcomment-37011703
UUID: 4f1ea46c-232b-54a6-9b17-cc2d0f3e6598 Repo: https://github.com/JuliaCloud/AWSCore.jl.git Tree: b498824bcf0792a8e16a92a48832321d5fb34581 Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
JuliaRegistrator
referenced
this pull request
in JuliaCloud/AWSCore.jl
Jan 29, 2020
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski **Resolves:** #107 ## Current Behaviour Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown. ## Expected Behaviour We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well. Now when you run the code example the request goes through successfully. ## Code Example ```julia using AWSCore.Services: route53 route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER") # ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME) ``` Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
|
I've created release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.