Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Result<T, E> as a return type from Rust -> C++ #404

Closed
4 tasks
ahayzen-kdab opened this issue Jan 9, 2023 · 0 comments
Closed
4 tasks

Support Result<T, E> as a return type from Rust -> C++ #404

ahayzen-kdab opened this issue Jan 9, 2023 · 0 comments
Assignees
@ahayzen-kdab
Labels
🪲 bug Something isn't working

Comments

@ahayzen-kdab
Copy link
Collaborator

ahayzen-kdab commented Jan 9, 2023 •
edited
Loading

https://cxx.rs/binding/result.html#returning-result-from-rust-to-c

We need to add support for returning a Result in invokables, this is tricky as the CXX and method types are different. Then Result is only supported in a return type and not a parameter (?).

Consider implementing the API ideas in dtolnay/cxx#1144 as part of this.

So

  • Have a separate cxx_utils module within cxx-qt-gen (which could then be made a crate)
  • Change the generator/cpp/types code into modular pieces
  • Move generator/rust/types into the same module
  • Add a separate method for when the type is a return type to support Result<T, E>
@ahayzen-kdab ahayzen-kdab added the 🪲 bug Something isn't working label Jan 9, 2023
@ahayzen-kdab ahayzen-kdab mentioned this issue Jan 9, 2023
Closed
9 tasks
@ahayzen-kdab ahayzen-kdab self-assigned this May 23, 2023
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue May 29, 2023
@ahayzen-kdab
cxx-qt-gen: split rust/types and cpp/types into a cxx utils module
542f78b 
This allows us to have a separate module for independent helpers
for dealing with syn, CXX, and C++ together.

Related to KDAB#404
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 29, 2023
Open
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
cxx-qt-gen: split rust/types and cpp/types into a cxx utils module
d985a12 
This allows us to have a separate module for independent helpers
for dealing with syn, CXX, and C++ together.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
cxx-qt-gen: add support for Result<T> as a return type
07a3944 
Closes KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
WIP: cxx-qt-gen: expand Result and Pin correct in Rust wrapper genera…
e018a3e 
…tion

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
WIP: examples: use Result in qml_features and test_inputs
83acfc3 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
091a222 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
@ahayzen-kdab ahayzen-kdab mentioned this issue Jun 22, 2023
Merged
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
0032e45 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 22, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
58e94da 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
b391c01 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
cxx-qt-gen: split rust/types and cpp/types into a cxx utils module
db82235 
This allows us to have a separate module for independent helpers
for dealing with syn, CXX, and C++ together.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
cxx-qt-gen: add support for Result<T> as a return type
371d610 
Closes KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
WIP: cxx-qt-gen: expand Result and Pin correct in Rust wrapper genera…
2e6e123 
…tion

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
WIP: examples: use Result in qml_features and test_inputs
c8b6336 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 4, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
9a7ba89 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 18, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
53294aa 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
fbdd653 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust invokables
0805af7 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: remove wrapper method for C++ -> Rust properties
2cacc35 
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.

Related to KDAB#404
@ahayzen-kdab ahayzen-kdab mentioned this issue Jul 19, 2023
Merged
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: split rust/types and cpp/types into a cxx utils module
63b6b1f 
This allows us to have a separate module for independent helpers
for dealing with syn, CXX, and C++ together.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: add support for Result<T> as a return type
f7a9040 
Closes KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
WIP: cxx-qt-gen: expand Result and Pin correct in Rust wrapper genera…
5212017 
…tion

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
WIP: examples: use Result in qml_features and test_inputs
3618ed4 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: split rust/types and cpp/types into a cxx utils module
56b4eb3 
This allows us to have a separate module for independent helpers
for dealing with syn, CXX, and C++ together.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 19, 2023
@ahayzen-kdab
cxx-qt-gen: add support for Result<T> as a return type
111ec20 
Closes KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: move impl Deref and impl CxxQtType to generator phase
38bf0de 
This allows us later to be able to used qualified mappings.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: parse types in the CXX bridge to generate qualified mappings
7429dc2 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified mappings in rust generation
424782d 
This means that we refer to MyObject as ffi::MyObject when it's a type.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified mappings in impl T as well
f660d79 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified name for T in constructor generation
24bd528 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: use CxxQtType in the setter as it needs rust_mut()
e6ca8c2 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: ensure that constructor and threading free methods are qu…
86a5233 
…alified

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: ensure that constructor parameters are qualified in impl
adb9468 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: remove hidden module
d45d994 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 24, 2023
@ahayzen-kdab
cxx-qt-gen: leave use statements in the CXX bridge
cf48196 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: move impl Deref and impl CxxQtType to generator phase
c121ce5 
This allows us later to be able to used qualified mappings.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: parse types in the CXX bridge to generate qualified mappings
1862e8e 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified mappings in rust generation
fc62e5d 
This means that we refer to MyObject as ffi::MyObject when it's a type.

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified mappings in impl T as well
963eaca 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: use qualified name for T in constructor generation
8092596 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: use CxxQtType in the setter as it needs rust_mut()
da8a19e 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: ensure that constructor and threading free methods are qu…
1477240 
…alified

Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: ensure that constructor parameters are qualified in impl
67c8f1a 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: remove hidden module
03efafe 
Related to KDAB#404
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jul 26, 2023
@ahayzen-kdab
cxx-qt-gen: leave use statements in the CXX bridge
8520c59 
Related to KDAB#404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: move impl Deref and impl CxxQtType to generator phase
02e3191 
This allows us later to be able to used qualified mappings.

Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: parse types in the CXX bridge to generate qualified mappings
0825c03 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: use qualified mappings in rust generation
4a185af 
This means that we refer to MyObject as ffi::MyObject when it's a type.

Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: use qualified mappings in impl T as well
048a2ba 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: use qualified name for T in constructor generation
2a66dc3 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: use CxxQtType in the setter as it needs rust_mut()
2e295d8 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: ensure that constructor and threading free methods are qu…
7bca80a 
…alified

Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: ensure that constructor parameters are qualified in impl
e0cf452 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: remove hidden module
9289753 
Related to #404
Be-ing pushed a commit that referenced this issue Jul 26, 2023
@ahayzen-kdab @Be-ing
cxx-qt-gen: leave use statements in the CXX bridge
5c555c2 
Related to #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahayzen-kdab ahayzen-kdab

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahayzen-kdab