cxx-qt-gen: remove wrapper method for C++ -> Rust invokables #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Jun 22, 2023
ahayzen-kdab
commented
Jun 22, 2023
ahayzen-kdab
added
the
🥳🎉 1.0
ahayzen-kdab
force-pushed
the
404-remove-invokable-wrapper-method
branch
2 times, most recently
from
0032e45 to
58e94da
Compare
ahayzen-kdab
commented
Jun 26, 2023
ahayzen-kdab
force-pushed
the
404-remove-invokable-wrapper-method
branch
2 times, most recently
from
b391c01 to
9a7ba89
Compare
|
Note if we use this trick, the same can be used for getters / setters etc for properties. |
|
After this change we could potentially pass through the invokable extern function blocks. |
ahayzen-kdab
force-pushed
the
404-remove-invokable-wrapper-method
branch
2 times, most recently
from
53294aa to
fbdd653
Compare
ahayzen-kdab
commented
Jul 19, 2023
|
Think we are going to assume this would be a regression in CXX if it did not work. |
This then avoids us needing to generate Rust methods with fully qualified types on the Rust side and removes a load of generation. Related to KDAB#404
ahayzen-kdab
force-pushed
the
404-remove-invokable-wrapper-method
branch
from
fbdd653 to
0805af7
Compare
This was referenced Jul 19, 2023
Be-ing
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This then avoids us needing to generate Rust methods with fully qualified types on the Rust side and removes a load of generation.
Related to #404