cxx-qt-gen: don't import Pin in hidden module resolving IDE integration #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
added
the
🥳🎉 1.0
ahayzen-kdab
commented
Jun 22, 2023
ahayzen-kdab
force-pushed
the
417-ensure-no-pin-import
branch
2 times, most recently
from
dbdbdcb to
b08c8d4
Compare
ahayzen-kdab
force-pushed
the
417-ensure-no-pin-import
branch
3 times, most recently
from
285215f to
e4d3217
Compare
6 tasks
Now that impls are outside of the bridge the developer needs to import Pin anyway. Closes KDAB#417
ahayzen-kdab
force-pushed
the
417-ensure-no-pin-import
branch
from
e4d3217 to
87b8364
Compare
Be-ing
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that impls are outside of the bridge the developer needs to import Pin anyway.
Closes #417
Requires #553