Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-gen: remove hidden module #618

Merged
merged 11 commits into from
Jul 26, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab commented Jul 19, 2023

Requires #617 #587 #620

And needs

  • Fully qualified types in generated methods, like parameters from signals UniquePtr -> cxx::UniquePtr (should be able to make a mechanism in the new utils/ to qualify a given syn type, then use that for other types like Pin too (slightly related to cxx-qt-gen: don't import Pin in hidden module resolving IDE integration #587) Have a generic mechanism in utils to do Pin, UniquePtr, SharedPtr etc which then removes the double definitions in cxx-qt-gen: don't import Pin in hidden module resolving IDE integration #587
  • impl MyObject needs to be impl module::MyObject or have a type/use to bring it in
  • Rust setters might need to have use cxx_qt::CxxQtType to be able to use rust_mut() in their methods, but we also don't want to import and "leak" that into the outside scope, so should just be in the method scope if required
  • Removed uses from ParsedCxxQtData
  • Qualify free methods calls to the bridge with the module ident
  • Arguments in the constructor need to pass through qualify

@ahayzen-kdab ahayzen-kdab added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label Jul 20, 2023
@ahayzen-kdab ahayzen-kdab force-pushed the 404-remove-hidden-module branch 6 times, most recently from e878d8f to cf48196 Compare July 24, 2023 16:08
@ahayzen-kdab ahayzen-kdab force-pushed the 404-remove-hidden-module branch from 6dcc30d to e49b9db Compare July 26, 2023 09:41
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review July 26, 2023 09:43
@ahayzen-kdab ahayzen-kdab changed the title WIP: cxx-qt-gen: remove hidden module cxx-qt-gen: remove hidden module Jul 26, 2023
@Be-ing Be-ing enabled auto-merge (rebase) July 26, 2023 14:12
@Be-ing Be-ing merged commit f5fa90c into KDAB:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants