cxx-qt-gen: remove wrapper method for C++ -> Rust properties #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
404-remove-property-wrapper-method
branch
from
2cacc35 to
9602329
Compare
6 tasks
Be-ing
previously approved these changes
Jul 20, 2023
This then avoids us needing to generate Rust methods with fully qualified types on the Rust side and removes a load of generation. Related to KDAB#404
ahayzen-kdab
dismissed
Be-ing’s stale review
The merge-base changed after approval.
ahayzen-kdab
force-pushed
the
404-remove-property-wrapper-method
branch
from
9602329 to
ef06ce5
Compare
ahayzen-kdab
added
the
🥳🎉 1.0
Be-ing
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This then avoids us needing to generate Rust methods with
fully qualified types on the Rust side and removes a load of
generation.
Related to #404
Requires #589