Support result return type #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
May 29, 2023
|
We will still need some work here with the new API, the Rust side won't change as now the developer writes the signature and the implementation. However we need to ensure that our type parser for creating the C++ type can support So some parts of this pull request will still be valid. |
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
from
6ee764b to
83acfc3
Compare
This was referenced Jun 22, 2023
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
from
83acfc3 to
c8b6336
Compare
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
2 times, most recently
from
3618ed4 to
7fc3692
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
from
7fc3692 to
a82f149
Compare
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
from
a82f149 to
c493991
Compare
This allows us to have a separate module for independent helpers for dealing with syn, CXX, and C++ together. Related to KDAB#404
Be-ing
force-pushed
the
404-support-result-return-type
branch
from
c493991 to
a6bcd37
Compare
And add a test to ensure we can catch a thrown exception. Related to KDAB#404
ahayzen-kdab
force-pushed
the
404-support-result-return-type
branch
from
a6bcd37 to
5d31396
Compare
Be-ing
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #589