Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Thumbs.db on install. #112

Closed
pjf opened this issue Oct 21, 2014 · 3 comments
Closed

Filter Thumbs.db on install. #112

pjf opened this issue Oct 21, 2014 · 3 comments
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Policy Issues with our policy

Comments

@pjf
Copy link
Member

pjf commented Oct 21, 2014

This file should never be in a mod in the first place, but authors
on Windows who just zip up their directory end up with it anyway.

It'd be nice to exclude it from installs.
@pjf pjf added Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality Easy This is easy to fix and removed Core (ckan.dll) Issues affecting the core part of CKAN labels Oct 21, 2014
@pjf pjf mentioned this issue Oct 21, 2014
Closed
@pjf pjf added the ★☆☆ label Oct 21, 2014
@AlexanderDzhoganov
Copy link
Member

Should we generally filter files based on just filename? When somebody makes a mod that has a legit thumbs.db file he's going to be very surprised.

@pjf
Copy link
Member Author

pjf commented Oct 21, 2014

Touché. Although that person is also likely in for a world of pain if they're developing under Windows. :)

This also gives me an idea for an awesome feature, but that will go in its own ticket.

@pjf pjf mentioned this issue Oct 21, 2014
Closed
@pjf pjf added the Policy Issues with our policy label Oct 21, 2014
@pjf pjf mentioned this issue Oct 22, 2014
Closed
@pjf
Copy link
Member Author

pjf commented Oct 26, 2014

Closing this in favour of #129.

@pjf pjf closed this as completed Oct 26, 2014
@pjf pjf removed the ★☆☆ label Oct 26, 2014
@pjf pjf mentioned this issue Dec 23, 2014
Closed
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Merge pull request KSP-CKAN#112 from RichardLake/Logging
a0b3371 
Add in some logging to the start-up progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Policy Issues with our policy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjf @AlexanderDzhoganov