Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bundles, optional install stanzas, and dependent stanzas #113

Closed
pjf opened this issue Oct 21, 2014 · 1 comment · Fixed by #209
Closed

Deprecate bundles, optional install stanzas, and dependent stanzas #113

pjf opened this issue Oct 21, 2014 · 1 comment · Fixed by #209
Assignees
@pjf
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality Policy Issues with our policy Spec Issues affecting the spec

Comments

@pjf
Copy link
Member

pjf commented Oct 21, 2014

After writing this post and combined with #110 and #112, there doesn't seem to be a great need for bundled mods, or optional sections.

This even works for previously thorny things like RSS bundling CustomBiomes with its own maps. We simply have CustomBiomes depend upon CustomBiomesData, and that can be provided by either CustomBiomesKerbal (which uses the same file as CustomBiomes), or RealSolarSystem.

This may mean that we'll want to support embedded CKAN/NetCKAN files which describe multiple mods that come from the same file, so things don't end up going out of sync in the future.
@pjf pjf added Core (ckan.dll) Issues affecting the core part of CKAN design Enhancement New features or functionality ★★☆ Policy Issues with our policy Spec Issues affecting the spec and removed design labels Oct 21, 2014
This was referenced Oct 26, 2014
Merged
Closed
@pjf pjf added In progress We're still working on this and removed ★★☆ labels Oct 31, 2014
@pjf pjf self-assigned this Oct 31, 2014
@pjf
Copy link
Member Author

pjf commented Oct 31, 2014

Working on this now. :)

pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Add filters. Deprecate bundles and install options.
e87b949 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
@pjf pjf mentioned this issue Oct 31, 2014
Merged
@pjf pjf added pull request and removed In progress We're still working on this labels Oct 31, 2014
@pjf pjf reopened this Oct 31, 2014
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Add filters. Deprecate bundles and install options.
1461d88 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
@pjf pjf closed this as completed in 5a5e9ee Oct 31, 2014
This was referenced Nov 16, 2014
Merged
Closed
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Add filters. Deprecate bundles and install options.
85f25db 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
RichardLake added a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@RichardLake
Merge pull request KSP-CKAN#113 from pjf/quieter_removal
d3b7f63 
Lower "not removing directory" messages to info level.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Merge pull request KSP-CKAN#113 from RichardLake/OutOfDate
73e6511 
Show incompatible but installed mods in the GUI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjf pjf

Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality Policy Issues with our policy Spec Issues affecting the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add filters, deprecate bundles and install options. pjf/CKAN
2 participants
@pjf @AlexanderDzhoganov