Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a filter keyword to install stanzas #129

Closed
pjf opened this issue Oct 22, 2014 · 2 comments · Fixed by #209
Closed

Add a filter keyword to install stanzas #129

pjf opened this issue Oct 22, 2014 · 2 comments · Fixed by #209
Assignees
@pjf
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality Spec Issues affecting the spec
Milestone
v1.0.0 - Galaxy Rise

Comments

@pjf
Copy link
Member

pjf commented Oct 22, 2014

It seems to be pretty common that we want to install things, but with a filter. For example:

"file" : "Some/Path",
"filter" : "thumbs.db",
"filter" : "NotThisFile.zip"

In particular, this would allow us to remove the need for #112, help with #127, and install Firespitter with the latest DLL at KSP-CKAN/CKAN-Meta#9.
@pjf pjf added Enhancement New features or functionality Spec Issues affecting the spec ★★★ labels Oct 22, 2014
@pjf pjf added this to the Usable Release milestone Oct 22, 2014
@pjf pjf added the Core (ckan.dll) Issues affecting the core part of CKAN label Oct 22, 2014
@pjf pjf mentioned this issue Oct 26, 2014
Closed
@pjf pjf added In progress We're still working on this and removed ★★★ labels Oct 30, 2014
@pjf pjf self-assigned this Oct 30, 2014
@pjf
Copy link
Member Author

pjf commented Oct 30, 2014

I'm considering two parts of this:

  • filter : which will cause a file to be skipped if it exactly matches the name (case insensitive). When this matches a directory name, that entire directory and its contents will be skipped. This does not examine the full path.
  • filter_regexp : Which does the same, but skips if the regexp matches, and always uses the full path contained within the zip-file.

The expectation is that most common tasks can be done with filter, and filter_regexp is there if something is particularly tricky.

I imagine we want both of these to be strings or arrays, and we'll skip a file if any filter matches.

pjf added a commit to pjf/CKAN that referenced this issue Oct 30, 2014
@pjf
Added Filter and Filter Regexpes to spec and code.
cddf585 
They don't do anything yet.
For KSP-CKAN#129.
@pjf
Copy link
Member Author

pjf commented Oct 31, 2014

Okay, I'm going to be removing support for bundles as part of this work. Hooray!

pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Added tests for filters.
e1c3d89 
As part of KSP-CKAN#129. Obviously these cause travis to fail without their corresponding code.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Add filters. Deprecate bundles and install options.
e87b949 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
@pjf pjf mentioned this issue Oct 31, 2014
Merged
@pjf pjf added pull request and removed In progress We're still working on this labels Oct 31, 2014
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Added Filter and Filter Regexpes to spec and code.
ae381a9 
They don't do anything yet.
For KSP-CKAN#129.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Added tests for filters.
96cc1f6 
As part of KSP-CKAN#129. Obviously these cause travis to fail without their corresponding code.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Add filters. Deprecate bundles and install options.
1461d88 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Added Filter and Filter Regexpes to spec and code.
30c6044 
They don't do anything yet.
For KSP-CKAN#129.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Added tests for filters.
d3fb43b 
As part of KSP-CKAN#129. Obviously these cause travis to fail without their corresponding code.
pjf added a commit to pjf/CKAN that referenced this issue Oct 31, 2014
@pjf
Add filters. Deprecate bundles and install options.
5a5e9ee 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
@pjf pjf mentioned this issue Dec 23, 2014
Closed
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Added Filter and Filter Regexpes to spec and code.
fd066d3 
They don't do anything yet.
For KSP-CKAN#129.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Add filters. Deprecate bundles and install options.
85f25db 
Updates the spec, the schema, and the code. Includes tests.

Closes KSP-CKAN#113 (deprecate things).
Closes KSP-CKAN#129 (add filter keywords).

This will require an update to CKAN-meta, which I've already got ready.
RichardLake added a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@RichardLake
Merge pull request KSP-CKAN#129 from mgsdk/fix_update_all_repos
64684d2 
Actually save the changes when we update all repos.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@Dazpoet
Merge pull request KSP-CKAN#129 from RichardLake/FixingTestMetadata
b862224 
Fixing incorrect metadata in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjf pjf

Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality Spec Issues affecting the spec
Projects
None yet
Milestone
v1.0.0 - Galaxy Rise
Development

Successfully merging a pull request may close this issue.

Add filters, deprecate bundles and install options. pjf/CKAN
2 participants
@pjf @AlexanderDzhoganov