style: various token changes #239

QuintonJason · 2024-08-12T17:26:50Z

Description

Tokens - added zeroes to 2 digit values
Tokens - apply change to component tokens
Font-size - correct 2 digit values
Colors - updated charcoal to grey mapping

Before	After

Fixes #(issue)
DSS-790

Type of change

Bug fix (non-breaking change which fixes an issue)

libs/core/src/components/pds-chip/pds-chip.scss

netlify · 2024-08-12T17:34:24Z

✅ Deploy Preview for pine-mercury-rising ready!

Name	Link
🔨 Latest commit	`7c03003`
🔍 Latest deploy log	https://app.netlify.com/sites/pine-mercury-rising/deploys/66bb9a1eaf11710008b7f5d9
😎 Deploy Preview	https://deploy-preview-239--pine-mercury-rising.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

libs/core/src/components/pds-link/pds-link.scss

ju-Skinner

There is an inconsistency between the token values for this change. It appears that all tokens should be changed to a non three-digit placeholder if they are only one or two digits.

anechol

Let's discuss these token name changes post-demo.

* fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267)

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267) style(loader): update default color to mercury_400 (#273) style: updates Avatar color styles (#274)

fix: update font size refs

6fb93ce

QuintonJason requested review from anechol, ju-Skinner and pixelflips and removed request for anechol and ju-Skinner August 12, 2024 17:26

QuintonJason self-assigned this Aug 12, 2024

QuintonJason marked this pull request as ready for review August 12, 2024 17:27

github-actions bot added bug Something isn't working package: core Changes have been made to the Core package mercury-rising Used for rebrand work labels Aug 12, 2024

pixelflips approved these changes Aug 12, 2024

View reviewed changes

QuintonJason requested review from pixelflips and ju-Skinner August 12, 2024 17:27

pixelflips approved these changes Aug 12, 2024

View reviewed changes

ju-Skinner reviewed Aug 12, 2024

View reviewed changes

libs/core/src/components/pds-chip/pds-chip.scss Outdated Show resolved Hide resolved

ju-Skinner reviewed Aug 12, 2024

View reviewed changes

libs/core/src/components/pds-link/pds-link.scss Outdated Show resolved Hide resolved

ju-Skinner requested changes Aug 12, 2024

View reviewed changes

QuintonJason added 2 commits August 12, 2024 17:43

fix: remove leading zero and correct font-size

4f44358

fix: update charcoal to grey

cc5963f

QuintonJason requested a review from ju-Skinner August 12, 2024 23:01

anechol requested changes Aug 12, 2024

View reviewed changes

QuintonJason and others added 4 commits August 13, 2024 10:00

fix: add back zeroes

733443d

fix: added zeroes to semantic tokens

25d73e1

fix: added zeroes to component token refs

d57bf6d

fix: update accordion padding

41a316d

QuintonJason requested a review from anechol August 13, 2024 16:31

ju-Skinner changed the title ~~fix: update font size refs~~ style: various token changes Aug 13, 2024

ju-Skinner merged commit 30ca88c into mercury-rising Aug 13, 2024
9 of 10 checks passed

ju-Skinner deleted the fix/update-font-size-refs branch August 13, 2024 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: various token changes #239

style: various token changes #239

QuintonJason commented Aug 12, 2024 •

edited

Loading

netlify bot commented Aug 12, 2024 •

edited

Loading

ju-Skinner left a comment

anechol left a comment

style: various token changes #239

style: various token changes #239

Conversation

QuintonJason commented Aug 12, 2024 • edited Loading

Description

Type of change

netlify bot commented Aug 12, 2024 • edited Loading

✅ Deploy Preview for pine-mercury-rising ready!

ju-Skinner left a comment

Choose a reason for hiding this comment

anechol left a comment

Choose a reason for hiding this comment

QuintonJason commented Aug 12, 2024 •

edited

Loading

netlify bot commented Aug 12, 2024 •

edited

Loading