fix: update box shadow tokens #241

QuintonJason · 2024-08-14T20:32:23Z

Description

update and apply box shadow tokens to match the figma design tokens
update sort function for token table

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In Token Studio
Box shadow tokens page

netlify · 2024-08-14T20:32:38Z

✅ Deploy Preview for pine-mercury-rising ready!

Name	Link
🔨 Latest commit	`8d13cc7`
🔍 Latest deploy log	https://app.netlify.com/sites/pine-mercury-rising/deploys/66be256975be6a0008d99b78
😎 Deploy Preview	https://deploy-preview-241--pine-mercury-rising.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pixelflips

There are a few usages in various locations, should we update those as well?

pixelflips

Left a comment for clarification. Let me know and I'll approve.

libs/core/src/components/pds-box/pds-box.tsx

anechol

Thanks for getting these updated. Only one minor issue below that needs addressing.

libs/core/src/components/pds-box/pds-box.tsx

libs/core/src/global/styles/tokens/core/_core.scss

* fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267)

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267) style(loader): update default color to mercury_400 (#273) style: updates Avatar color styles (#274)

fix: add box shadow tokens

b40c2ab

github-actions bot added bug Something isn't working package: core Changes have been made to the Core package mercury-rising Used for rebrand work labels Aug 14, 2024

fix: add box shadow build tokens

dc37bc4

QuintonJason marked this pull request as ready for review August 14, 2024 21:29

QuintonJason requested review from ju-Skinner, pixelflips, anechol and a team and removed request for ju-Skinner and anechol August 14, 2024 21:29

pixelflips reviewed Aug 14, 2024

View reviewed changes

QuintonJason and others added 4 commits August 15, 2024 08:54

fix: update box-shadow tokens

61fa111

fix: update box shadow tokens

4940177

fix: add and apply box shadow tokens

e31705a

fix: update sort function

ba382dd

github-actions bot added the package: doc-componenets label Aug 15, 2024

QuintonJason requested a review from pixelflips August 15, 2024 15:51

pixelflips reviewed Aug 15, 2024

View reviewed changes

libs/core/src/components/pds-box/pds-box.tsx Outdated Show resolved Hide resolved

fix: typo

8d13cc7

anechol requested changes Aug 15, 2024

View reviewed changes

libs/core/src/components/pds-box/pds-box.tsx Outdated Show resolved Hide resolved

libs/core/src/global/styles/tokens/core/_core.scss Show resolved Hide resolved

pixelflips approved these changes Aug 15, 2024

View reviewed changes

anechol approved these changes Aug 15, 2024

View reviewed changes

QuintonJason self-assigned this Aug 15, 2024

QuintonJason merged commit 2c844e9 into mercury-rising Aug 15, 2024
16 checks passed

QuintonJason deleted the fix/mercury-rising-box-shadow-real branch August 15, 2024 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update box shadow tokens #241

fix: update box shadow tokens #241

QuintonJason commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

pixelflips left a comment •

edited

Loading

pixelflips left a comment

anechol left a comment

fix: update box shadow tokens #241

fix: update box shadow tokens #241

Conversation

QuintonJason commented Aug 14, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

netlify bot commented Aug 14, 2024 • edited Loading

✅ Deploy Preview for pine-mercury-rising ready!

pixelflips left a comment • edited Loading

Choose a reason for hiding this comment

pixelflips left a comment

Choose a reason for hiding this comment

anechol left a comment

Choose a reason for hiding this comment

QuintonJason commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

pixelflips left a comment •

edited

Loading