style: adds base/reset CSS file #256

anechol · 2024-09-11T16:19:18Z

Description

Adds a shared base/reset file to all components. This will allow us to get rid of repetitive style declarations within components such as font styles and typical reset styles, as well as address some minor issues like the [hidden] attribute being overridden by more specific selectors. There are no additional network requests made for these added styles. The styles are bundled up and combined into one stylesheet when the component is built.

If there's another approach that might work better, keeping in mind to not interfere with styles outside of the components and keeping specificity as low as possible, please share your ideas!

DSS-863

Type of change

Style (adds, removes, or refactors component styling)

How Has This Been Tested?

Please make sure all components look as expected. The base file has also been updated with most of the needed semantic tokens.

Test Configuration:

Pine versions:
OS:
Browsers:
Screen readers:
Misc:

Checklist:

If not applicable, leave options unchecked.

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing tests pass locally with my changes
Design has QA'ed and approved this PR

netlify · 2024-09-11T16:19:34Z

✅ Deploy Preview for pine-mercury-rising ready!

Name	Link
🔨 Latest commit	`92fde2f`
🔍 Latest deploy log	https://app.netlify.com/sites/pine-mercury-rising/deploys/66ec68d56042c000084574a9
😎 Deploy Preview	https://deploy-preview-256--pine-mercury-rising.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ju-Skinner · 2024-09-12T12:35:48Z

libs/core/src/components/pds-accordion/stories/pds-accordion.stories.js

+    <pds-box align-items="center" slot="label">
+      <pds-icon name="product"></pds-icon>
+      <span style="display: inline-block; margin-left: 8px;">Products</span>
+    </pds-box>
+    <pds-box direction="column" gap="xs" padding="xs">
+      <pds-link variant="plain" href="#">All products</pds-link>
+      <pds-link variant="plain" href="#">Courses</pds-link>
+      <pds-link variant="plain" href="#">Coaching</pds-link>
+      <pds-link variant="plain" href="#">Community</pds-link>
+      <pds-link variant="plain" href="#">Podcasts</pds-link>
+    </pds-box>


Did you intend to commit this with this effort?

Yes this was on purpose. Just removing an unneeded pds-row.

ju-Skinner · 2024-09-12T12:36:25Z

libs/core/src/global/styles/base.scss

@@ -0,0 +1,121 @@
+// TODO: replace core tokens with semantic


do we still need this todo?

Yes, I still have some semantic type tokens to create. I should be getting that done today, but those are separate tickets.

pixelflips

A couple of non-blocking nitpicks, otherwise LGTM! Great work!

pixelflips · 2024-09-12T15:34:25Z

libs/core/.stylelintignore

+src/global/styles/tokens/semantic/*.scss
+src/global/styles/base.scss


nitpick: file missing new line at end

pixelflips · 2024-09-12T15:34:42Z

libs/core/src/global/styles/app.scss

 @use 'tokens/index';
+@use 'fonts';


nitpick: file missing new line at end

QuintonJason · 2024-09-12T19:50:58Z

libs/core/src/global/styles/base.scss

+  Josh's Custom CSS Reset
+  https://www.joshwcomeau.com/css/custom-css-reset/
+*/
+:where(*:not(slot), *:not(slot)::before, *:not(slot)::after) {


QuintonJason

Great stuff!

…nents

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267)

* Tokens - Adds New Rebrand Colors and Font (#222) * style: adds new rebrand color tokens * style: remaps old charcoal semantic tokens to new gray * style: builds new color tokens * style: updates yellow 200 * style: updates token values * style: builds updated token set * style: updates tokens with new names * style: updates semantic references * style: updates Circular font family token to Greet * style: corrects color token values * style: fixes semantic token references * style: build new token set * style: changes "gray" to "gray" * style: builds grey tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Letter Spacing (#223) * style: adds new letter spacing tokens and removes 0 from some font size and line height values * style: builds new letter spacing tokens * style: updates font size, removes typography semantic tokens, and removes leading zero on remaining tokens * style: builds new tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Update Typography Tokens (#225) * style: updates font weight values, adds a new line height value, and correct font family value * style: builds new type tokens * style: fixes type changes * style: builds fixed tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Adds Initial Semantic Tokens (#226) * style: adds initial semantic tokens * style: builds new semantic tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Tokens: Creates Semantic Type Tokens (#227) * style: builds new semantic type tokens * style: readds missing tokens in JSON * style: builds missing tokens --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> chore: publish - @pine-ds/core@2.0.0-mercury.0 - @pine-ds/doc-components@2.0.0-mercury.0 - @pine-ds/react@2.0.0-mercury.0 Publish - @pine-ds/core@3.0.0-mercury.0 - @pine-ds/doc-components@3.0.0-mercury.0 - @pine-ds/react@3.0.0-mercury.0 styles: updates font weight, letter spacing, and font size (#230) * chore: update doc-components version (#228) * style: reverts semantic font weights back to 100 scale * style: updates letter spacing for body type * style: updates xs font size to 12px * style: build updated tokens * chore: package-lock update * ci: update @tokens-studio/sd-transforms package to the latest version * chore: adds necessary preprocessor to script file to fix shadow tokens --------- Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com> Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@4.0.0-mercury.0 - @pine-ds/doc-components@4.0.0-mercury.0 - @pine-ds/react@4.0.0-mercury.0 style(link): correct token naming for icon spacing (#234) Publish - @pine-ds/core@5.0.0-mercury.0 - @pine-ds/doc-components@5.0.0-mercury.0 - @pine-ds/react@5.0.0-mercury.0 Typography: add new fonts (#233) * style: adds new fonts to Pine * chore: fixes style linting issues Publish - @pine-ds/core@6.0.0-mercury.0 - @pine-ds/doc-components@6.0.0-mercury.0 - @pine-ds/react@6.0.0-mercury.0 gi: update versions to correct version numbers the builds for mercury were using premajor when it should have been preminor after the first mercury release Publish - @pine-ds/core@2.1.0-mercury.0 - @pine-ds/doc-components@2.1.0-mercury.0 - @pine-ds/react@2.1.0-mercury.0 Accordion: Minor Styling Updates (#238) * style: fixes accordion body padding and some deprecated tokens * style: updates font styles of summary trigger Publish - @pine-ds/core@2.2.0-mercury.0 - @pine-ds/doc-components@2.2.0-mercury.0 - @pine-ds/react@2.2.0-mercury.0 style: update various color tokens (#236) * style: update various color tokens * style: update various color tokens Publish - @pine-ds/core@2.3.0-mercury.0 - @pine-ds/doc-components@2.3.0-mercury.0 - @pine-ds/react@2.3.0-mercury.0 style: various token changes (#239) * fix: update font size refs * fix: remove leading zero and correct font-size * fix: update charcoal to grey * fix: add back zeroes * fix: added zeroes to semantic tokens * fix: added zeroes to component token refs * fix: update accordion padding * fix: added back 0 Publish - @pine-ds/core@2.4.0-mercury.0 - @pine-ds/doc-components@2.4.0-mercury.0 - @pine-ds/react@2.4.0-mercury.0 fix: update box shadow tokens (#241) * fix: add box shadow tokens * fix: add box shadow build tokens * fix: update box-shadow tokens * fix: update box shadow tokens * fix: add and apply box shadow tokens * fix: update sort function * fix: typo Publish - @pine-ds/core@2.5.0-mercury.0 - @pine-ds/doc-components@2.5.0-mercury.0 - @pine-ds/react@2.5.0-mercury.0 Publish - @pine-ds/core@2.6.0-mercury.0 - @pine-ds/doc-components@2.6.0-mercury.0 - @pine-ds/react@2.6.0-mercury.0 style: updates accordion styling to better match Figma specs (#245) Publish - @pine-ds/core@2.7.0-mercury.0 - @pine-ds/doc-components@2.7.0-mercury.0 - @pine-ds/react@2.7.0-mercury.0 Publish - @pine-ds/core@2.8.0-mercury.0 - @pine-ds/doc-components@2.8.0-mercury.0 - @pine-ds/react@2.8.0-mercury.0 Publish - @pine-ds/core@2.9.0-mercury.0 - @pine-ds/doc-components@2.9.0-mercury.0 - @pine-ds/react@2.9.0-mercury.0 Publish - @pine-ds/core@2.10.0-mercury.0 - @pine-ds/doc-components@2.10.0-mercury.0 - @pine-ds/react@2.10.0-mercury.0 style(tabs): change the active tab color to mercury 500 (#248) Publish - @pine-ds/core@2.11.0-mercury.0 - @pine-ds/doc-components@2.11.0-mercury.0 - @pine-ds/react@2.11.0-mercury.0 style: update focus state width and color style: correct lint error style: correct lint error style: remove extra semicolon Publish - @pine-ds/core@2.12.0-mercury.0 - @pine-ds/doc-components@2.12.0-mercury.0 - @pine-ds/react@2.12.0-mercury.0 style(button): change border radius to 9999px (#251) style(button): change the colors for the accent variant to be purple (#253) ci: fix lerna version command to use preminor Publish - @pine-ds/core@2.15.0-mercury.0 - @pine-ds/doc-components@2.15.0-mercury.0 - @pine-ds/react@2.15.0-mercury.0 style: add relative position for focus (#259) Publish - @pine-ds/core@2.16.0-mercury.0 - @pine-ds/doc-components@2.16.0-mercury.0 - @pine-ds/react@2.16.0-mercury.0 chore: fixes issue with sd-transforms caused by version update (#260) Publish - @pine-ds/core@2.17.0-mercury.0 - @pine-ds/doc-components@2.17.0-mercury.0 - @pine-ds/react@2.17.0-mercury.0 style: updates button font family and font weight (#258) Publish - @pine-ds/core@2.18.0-mercury.0 - @pine-ds/doc-components@2.18.0-mercury.0 - @pine-ds/react@2.18.0-mercury.0 style: add typography semantic tokens (#262) * style: adds semantic typography tokens * style: updates body letter spacing semantic token * style: removes letter spacing from font declaration to prevent warnings on build * chore: updates build file with API changes and builds updated tokens * chore: fixes tokens table variables due to token format change * chore: update packages for token-studio and style-dictionary --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Co-authored-by: Julian Skinner <ju.skinner@gmail.com> Publish - @pine-ds/core@2.19.0-mercury.0 - @pine-ds/doc-components@2.19.0-mercury.0 - @pine-ds/react@2.19.0-mercury.0 style: add sprig font face (#263) * style: add Faire Sprig font family * style(token-studio): add sprig token * style(tokens): add sprig font-family to core --------- Co-authored-by: Kajabi Automations Bot <120066875+dev-kjbot@users.noreply.github.com> Publish - @pine-ds/core@2.20.0-mercury.0 - @pine-ds/doc-components@2.20.0-mercury.0 - @pine-ds/react@2.20.0-mercury.0 style: adds base/reset CSS file (#256) * style: adds a base scss file with reset and base styles * style: adds base/reset CSS file and adds to every component * chore: ignores base file for linting issues * chore: adds new lines to changed files * fix: fixes issue with reset styles leaking out from box and row components * chore: replaces most core tokens in reset with semantic tokens * chore: fixes linting issue * style: removes default color from reset file Publish - @pine-ds/core@2.21.0-mercury.0 - @pine-ds/doc-components@2.21.0-mercury.0 - @pine-ds/react@2.21.0-mercury.0 feat(accordion): adds part to accordion component (#264) Publish - @pine-ds/core@2.22.0-mercury.0 - @pine-ds/doc-components@2.22.0-mercury.0 - @pine-ds/react@2.22.0-mercury.0 style(button): change button font-weight to med (500) (#267) style(loader): update default color to mercury_400 (#273) style: updates Avatar color styles (#274)

anechol self-assigned this Sep 11, 2024

github-actions bot added package: core Changes have been made to the Core package package: react Changes have been made to the React package package: doc-componenets mercury-rising Used for rebrand work labels Sep 11, 2024

anechol force-pushed the style/add-base-reset-css branch from 27b735b to 03aa9fa Compare September 11, 2024 18:41

anechol marked this pull request as ready for review September 11, 2024 20:28

anechol requested review from pixelflips, QuintonJason, ju-Skinner, FuturaExtraBold and monicawheeler September 11, 2024 20:28

ju-Skinner reviewed Sep 12, 2024

View reviewed changes

pixelflips approved these changes Sep 12, 2024

View reviewed changes

QuintonJason reviewed Sep 12, 2024

View reviewed changes

QuintonJason approved these changes Sep 12, 2024

View reviewed changes

anechol force-pushed the style/add-base-reset-css branch from f0f61dd to 76d7d23 Compare September 17, 2024 19:57

anechol marked this pull request as draft September 18, 2024 16:25

anechol force-pushed the style/add-base-reset-css branch from cd22e0d to f5d8549 Compare September 18, 2024 16:26

anechol marked this pull request as ready for review September 18, 2024 20:38

anechol requested review from ju-Skinner, pixelflips and QuintonJason September 18, 2024 20:38

pixelflips approved these changes Sep 18, 2024

View reviewed changes

QuintonJason approved these changes Sep 18, 2024

View reviewed changes

anechol added 3 commits September 19, 2024 13:09

style: adds a base scss file with reset and base styles

0b254b9

style: adds base/reset CSS file and adds to every component

cb89976

chore: ignores base file for linting issues

30e6fb8

anechol added 5 commits September 19, 2024 13:09

chore: adds new lines to changed files

ceb0365

fix: fixes issue with reset styles leaking out from box and row compo…

403fe50

…nents

chore: replaces most core tokens in reset with semantic tokens

8d37ec9

chore: fixes linting issue

5facfca

style: removes default color from reset file

92fde2f

anechol force-pushed the style/add-base-reset-css branch from bc8dc73 to 92fde2f Compare September 19, 2024 18:09

anechol merged commit b58ad6e into mercury-rising Sep 19, 2024
16 checks passed

anechol deleted the style/add-base-reset-css branch September 19, 2024 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: adds base/reset CSS file #256

style: adds base/reset CSS file #256

anechol commented Sep 11, 2024 •

edited

Loading

netlify bot commented Sep 11, 2024 •

edited

Loading

ju-Skinner Sep 12, 2024

anechol Sep 12, 2024

ju-Skinner Sep 12, 2024

anechol Sep 12, 2024

pixelflips left a comment

pixelflips Sep 12, 2024

pixelflips Sep 12, 2024

QuintonJason Sep 12, 2024

QuintonJason left a comment

		src/global/styles/tokens/semantic/*.scss
		src/global/styles/base.scss

style: adds base/reset CSS file #256

style: adds base/reset CSS file #256

Conversation

anechol commented Sep 11, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

netlify bot commented Sep 11, 2024 • edited Loading

✅ Deploy Preview for pine-mercury-rising ready!

ju-Skinner Sep 12, 2024

Choose a reason for hiding this comment

anechol Sep 12, 2024

Choose a reason for hiding this comment

ju-Skinner Sep 12, 2024

Choose a reason for hiding this comment

anechol Sep 12, 2024

Choose a reason for hiding this comment

pixelflips left a comment

Choose a reason for hiding this comment

pixelflips Sep 12, 2024

Choose a reason for hiding this comment

pixelflips Sep 12, 2024

Choose a reason for hiding this comment

QuintonJason Sep 12, 2024

Choose a reason for hiding this comment

QuintonJason left a comment

Choose a reason for hiding this comment

anechol commented Sep 11, 2024 •

edited

Loading

netlify bot commented Sep 11, 2024 •

edited

Loading