Send authors to API

[3v0k4]

Send masked authors to API:

• build_author is the name and email of the author for the last commit
• commit_authors is author (as above) + number of commits obtained by grouping all the commits of the last month

A git fetch is performed to make sure the last months of commits are available in case the repository is performing shallow clones for performance reasons.

Notice that this solution respects gitmailmap, which could be useful to customers/us.

See also https://github.com/KnapsackPro/knapsack-pro-api/pull/726

[shadre]

Looks Neat To me 🚀

[ArturT]

I left a few ideas on what we could improve.

[ArturT]

We could do a performance improvement here and move the lines down below. I completely forgot about it. Just noticed it now.

We can send build author and commit authors only in the request that supposed to initialize a new queue. Thanks to that we don't have to transfer unnecessary data over the network for each Queue API request that is consuming tests from the Queue. Similarly like we do for test files.

Additional benefit of that approach is that we don't have to call git command on each request. I guess this could cause a small delay in running tests if you call git many times on each CI node for each request.

            if request_hash[:can_initialize_queue] && !request_hash[:attempt_connect_to_queue]
                request_hash.merge!({
                  :test_files => args.fetch(:test_files),
                  :build_author => KnapsackPro::RepositoryAdapters::GitAdapter.new.build_author,
                  :commit_authors => KnapsackPro::RepositoryAdapters::GitAdapter.new.commit_authors
                })
            end

[3v0k4]

3b871c0

[ArturT]

If you run knapsack pro locally on your machine, you call --shallow-since command and when I want to use git blame, I only see commits from the last month.

I undo changes by using the following command:

git fetch --unshallow || git fetch --all

I guess someone might not like that we mess up with their local repository when they try to run Knapsack Pro locally.

[3v0k4]

Thanks for the report.

[ArturT]

For reference: The above issue will be solved when we run --shallow-since only in the context of the CI. This PR solves it:

• Improve commit authors tracking #209