update librustzcash #1
Open
+101,800
−21,954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_sqlite-0.12.2-merge
…-merge `zcash_client_sqlite` version 0.12.2 post-hotfix merge
…ategy zcash_client_backend: Implement note management via change splitting.
…ic migration state.
…scind that determination. This is a minimal and correct but incomplete fix for #1571. Additional work to distinguish change outputs is necessary to update existing wallets that have made an incorrect change determination in the past.
…tly flagged when recording sent outputs. Fixes #1571
zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged.
…address` methods.
fixed fees are not standard), and deprecate `fixed::FeeRule::non_standard`. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
zcash_client_backend: Remove deprecated and duplicative wallet APIs.
Add `merge_group:` trigger to CI workflow.
This enables us to add a single "required status check" to the GitHub repo settings, that covers all required matrix job cases.
CI: Add a job that runs when all required status checks pass
RPIT (return-position `impl Trait`) was stabilized in Rust 1.75, and the `dynosaur` crate providing dynamic dispatch support was published two weeks ago. Now that our MSRV is 1.77, we can use both of these.
zcash_client_backend: Switch from `async-trait` to RPIT for `tor` module
…gration. This test is not specific to the migration; it's a more general test of ephemeral address rotation behavior and should evolve with the evolution of address rotation and gap limit handling, not be tied to the behavior of methods at the time that this migration was created.
This permits `UnifiedAddressRequest` values an additional dimension of flexibility, permitting generation of unified addresses having receivers for all recever types for which a key item exists and a diversifier index is valid.
This removes a `fix_bad_change_flagging` migration test duplicated from `zcash_client_backend::data_api::testing::pool::shiled_transparent`. It is impractical to maintain backwards compatibility to earlier database states for the entire test harness, which is more or less what retaining this test would require, and the desired outcome is already demonstrated by the `shield_transparent` test; demonstrating the fix directly is unnecessary.
…handling-prep Preparatory refactoring for #1673
The bug was fixed in zcash/lightwalletd@b805382, and the workaround doesn't work with backed by zebrad.
zcash_client_backend: Remove lightwalletd workaround
Instead the PCZT is parsed into its protocol-specific types, and getters on those are used. The remaining getters are used for sighash derivation, the one part of the stack that is not currently modular.
Changes required for Keystone firmware support
Update changelogs with dependency bumps from Keystone PR
…protocol` This fixes a few errors that have been introduced over time since `zcash_extensions` is not regularly built, and migrates `zcash_extensions` to eliminate the use of deprecated `zcash_primitives` APIs.
As of `nonempty 0.11`, `nonempty` is `no-std` compatible and therefore the `nonempty` dependency no longer needs to be optional.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
`zcash_primitives`: Add `no_std` support
This commit on its own doesn't expand the public API, as such `WalletDb`s cannot be constructed.
This requires `C: Borrow<rusqlite::Connection>` to ensure that at least `WalletRead` is accessible. It enables construction of the following additional types: - `WalletDb<&rusqlite::Connection, _>` - `WalletDb<&mut rusqlite::Connection, _>`
zcash_client_sqlite: Enable constructing `WalletDb` around references to `rusqlite::Connection`
Remove `devtools` crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.