fix(ai-proxy): add analytics for chat route_type of anthropic
#12781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
|
The failure of test cases should probably be fixed after #12699. |
liverpool8056
force-pushed
the
analytics-for-Anthropic
branch
from
40e970d
to
4b22892
Compare
log statistics, and fix a bug that Anthropic don't provide log statistics in `chat` route_type. FTI-5769
2. remain completions of anthropic only in the unsupported api
liverpool8056
force-pushed
the
analytics-for-Anthropic
branch
from
0320f7b
to
bc0beaf
Compare
tysoekong
approved these changes
Apr 11, 2024
flrgh
approved these changes
Apr 11, 2024
|
Successfully created cherry-pick PR for |
3 tasks
liverpool8056
added a commit
that referenced
this pull request
Apr 16, 2024
In this PR, a database migration is added for AI-proxy plugin, disabling the log_statistics feature of this plugin for providers not supporting this feature. Also, a changelog entry is added as well to describe it.
windmgc
pushed a commit
that referenced
this pull request
Apr 22, 2024
This PR is a follow-up one of #12781. In #12781 , the default value of log_statistics is changed from true to false for providers not supporting this feature, and a configuration validation is added to prevent from enabling it against those unsupported providers. However, the new config validation may cause CP DP compatibility issue in case that log_statistics has been enabled upon those unsupported providers. Although the issue can only happen in a very narrow case, it would be better to take care of it. In this PR, a database migration is added for the case mentioned above, migrating the value of log_statistics from true to false against providers not supporting this feature. Also, a changelog entry is added as well to describe it.
windmgc
pushed a commit
that referenced
this pull request
Apr 22, 2024
#12854) There is a bit difference in the usage data between ai providers, and considering the variability of it, this PR attempts to improve the robustness during the process of transforming the usage data when: no usage data provided in the upstream response; some possible changes in structure of usage data in the future; In #12781 , it is arbitrarily believed that the usage data is always included and the data struct won't change. This may be a potential issue throwing an error. Therefore, this PR is a follow-up one to prevent from it.
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
There is a bit difference in the usage data between ai providers, and considering the variability of it, this PR attempts to improve the robustness during the process of transforming the usage data when: no usage data provided in the upstream response; some possible changes in structure of usage data in the future; In #12781 , it is arbitrarily believed that the usage data is always included and the data struct won't change. This may be a potential issue throwing an error. Therefore, this PR is a follow-up one to prevent from it. (cherry picked from commit a22d696) Co-authored-by: Robin Xiang <liverpool8056@163.com>
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
This PR is a follow-up one of #12781. In #12781 , the default value of log_statistics is changed from true to false for providers not supporting this feature, and a configuration validation is added to prevent from enabling it against those unsupported providers. However, the new config validation may cause CP DP compatibility issue in case that log_statistics has been enabled upon those unsupported providers. Although the issue can only happen in a very narrow case, it would be better to take care of it. In this PR, a database migration is added for the case mentioned above, migrating the value of log_statistics from true to false against providers not supporting this feature. Also, a changelog entry is added as well to describe it. (cherry picked from commit f3b6b2e) --------- Co-authored-by: Robin Xiang <liverpool8056@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix a bug that the analystics is not included in the response of the
chatroute_type of anthropicChecklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5769