fix(router) anchor regex paths in traditional_compatible mode #9394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The traditional router would use the `a` (anchor) flag when evaluating input to ensure regex paths only match from the start of the string. Given the route path `/prefix/[0-9]+`: GET /prefix/123 => match GET /extra/prefix/123 => no match This updates the traditional_compatible router to replicate the same behavior. The underlying atc router library does not support regex flags, so we accomplish this by prepending the regex with `^`.
aboudreault
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
LGTM, better to wait a second approval from someone that know well the new router. @dndx
dndx
reviewed
Sep 7, 2022
1 task
dndx
approved these changes
Sep 7, 2022
dndx
pushed a commit
that referenced
this pull request
Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant #9327 * transplant #9329 * transplant #9343 * transplant #9346 * transplant #9357 * transplant #9389 * transplant #9394 * transplant #9451 * transplant #9480
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant Kong#9327 * transplant Kong#9329 * transplant Kong#9343 * transplant Kong#9346 * transplant Kong#9357 * transplant Kong#9389 * transplant Kong#9394 * transplant Kong#9451 * transplant Kong#9480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traditional router would use the
a(anchor) flag when evaluating input to ensure regex paths only match from the start of the string.Given the route path
/prefix/[0-9]+(<=2.8) or~/prefix/[0-9]+(>=3.0):GET /prefix/123GET /extra/prefix/123This updates the traditional_compatible router to replicate the same behavior. The underlying atc router library does not support regex flags, so we accomplish this by prepending the regex with
^.