fix(router/atc): check expression building error #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dndx
requested changes
Sep 28, 2022
chronolaw
force-pushed
the
fix/handle_router_rebuild_error
branch
from
40f40eb
to
0f04907
Compare
This was referenced Sep 29, 2022
dndx
reviewed
Oct 6, 2022
kong/router/atc_compat.lua
Outdated
| new_updated_at = max(new_updated_at, route.updated_at or 0) | ||
|
|
||
| else | ||
| ngx_log(ngx_WARN, err) |
There was a problem hiding this comment.
This seems to be an error level log, also we should add more error context to the message.
There was a problem hiding this comment.
I think that the err returned by add_atc_matcher has enough information of context. Do we need more?
add test case update test case update changelog check rebuilding flag remove rebuilding check integration test case test code clean add #db tag remove ngx.sleep fix error message use ngx.ERR level
chronolaw
force-pushed
the
fix/handle_router_rebuild_error
branch
from
2844494
to
16c8e5a
Compare
dndx
reviewed
Oct 8, 2022
dndx
approved these changes
Oct 9, 2022
dndx
pushed a commit
that referenced
this pull request
Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant #9327 * transplant #9329 * transplant #9343 * transplant #9346 * transplant #9357 * transplant #9389 * transplant #9394 * transplant #9451 * transplant #9480
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant Kong#9327 * transplant Kong#9329 * transplant Kong#9343 * transplant Kong#9346 * transplant Kong#9357 * transplant Kong#9389 * transplant Kong#9394 * transplant Kong#9451 * transplant Kong#9480
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix FT-3429